Skip to contentSkip to conversation

HP300 LANCE

PATCH Chuck Ebbert 1 participant 1 message Nov 1, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · On Sun, 31 Oct 2004 at 02:48:40 -0800 Andrew Morton <[email protected]> wrote:

It comes out visually OK once the patch is applied. But it's a useful reminder of how much dreck we have in the tree.

That's for sure:

[me@nb linux-2.6.9]$ find . -name "*.[ch]" | xargs egrep -H -n '^[[:space:]]+if\(' | \

Quoted 1 line

tee if_should_be_followed_by_space | wc -l

18991

And my favorite pet peeve:

[me@nb linux-2.6.9]$ find . -name "*.[ch]" | \

Quoted 2 lines

xargs egrep -H -n '^[[:space:]]+return[[:space:]]*\([^)]+\);' | \
tee return_is_not_a_function | wc -l

9867

There are a lot more than that but I could find no obvious way of including "return(parenthesized expr)" while excluding "return (typecast)(expr)".

--Chuck Ebbert 31-Oct-04 23:46:37