m68k: smp_lock.h: Avoid recursive include
Quoted 11 lines · Linus Torvalds
This one is _totally_ broken.
Not only is that include not recursive, but it immediately breaks any SMP compile because that header file _needs_ the definition of "
task_struct".Quoted 3 lines · Geert Uytterhoeven
smp_lock.h: Avoid recursive include
Quoted 7 lines
include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200 line 5
Quoted 7 lines
include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200 renamed from include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200 +0
-1@@ -2,7 +2,6 @@ #define __LINUX_SMPLOCK_H #include <linux/config.h> -#include <linux/sched.h>
Shouldn't you also revert cset 1.2405, also by Geert, which added <linux/sched.h> to reiserfs_fs.h? Looks like that was done to fix breakage caused by this change.
--Chuck Ebbert 02-Nov-04 03:48:03
Quoted 14 lines · Chuck Ebbert
Quoted 13 lines · Linus Torvalds
This one is _totally_ broken.
Not only is that include not recursive, but it immediately breaks any SMP compile because that header file _needs_ the definition of "
task_struct".Quoted 7 lines · Geert Uytterhoeven
smp_lock.h: Avoid recursive includeinclude/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200 renamed from include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200 +0
-0@@ -2,7 +2,6 @@ #define __LINUX_SMPLOCK_H
Quoted 7 lines
Quoted 2 lines
include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200 line 5
Quoted 2 lines
include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200 renamed from include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200 +0
-1#include <linux/config.h> -#include <linux/sched.h>Shouldn't you also revert cset 1.2405, also by Geert, which added <
linux/sched.h> toreiserfs_fs.h? Looks like that was done to fix breakage caused by this change.
You can discuss about that: reiserfs_fs.h used current including sched.h.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 23 lines · Geert Uytterhoeven
Quoted 14 lines · Chuck Ebbert
Quoted 13 lines · Linus Torvalds
This one is _totally_ broken.
Not only is that include not recursive, but it immediately breaks any SMP compile because that header file _needs_ the definition of "
task_struct".Quoted 7 lines · Geert Uytterhoeven
smp_lock.h: Avoid recursive includeinclude/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200 renamed from include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200 +0
-0@@ -2,7 +2,6 @@ #define __LINUX_SMPLOCK_HQuoted 7 lines
Quoted 2 lines
include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200 line 5
Quoted 2 lines
include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200 renamed from include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200 +0
-1#include <linux/config.h> -#include <linux/sched.h>Shouldn't you also revert cset 1.2405, also by Geert, which added <
linux/sched.h> toreiserfs_fs.h? Looks like that was done to fix breakage caused by this change.
Quoted 1 line
You can discuss about that:
reiserfs_fs.hused current includingsched.h.
^
Oops, there's a missing `without' here...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds