Skip to contentSkip to conversation

lib/vsprintf.c

oops Paweł Sikora 5 participants 10 messages Nov 2, 2004

lore
Share & tools
lore
#0 lore raw

Hi,

vsprintf.c- case 's':
vsprintf.c- s = va_arg(args, char *);
vsprintf.c- if ((unsigned long)s < PAGE_SIZE)
vsprintf.c- s = "<NULL>";
vsprintf.c-
vsprintf.c: OOPS! => len = strnlen(s, precision);

Signature · 3 lines
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)
Unable to handle kernel paging request at virtual address 66666666
 printing eip:
c01b6f3e
*pde = 00131313
*pte = 0c55b70f
Oops: 0000 [#1]
Modules linked in: oops videodev agpgart nvidia ipt_unclean ipt_state

ipt_REJECT iptable_nat ip_conntrack iptable_mangle iptable_filter ip_tables vmmon snd_seq_oss snd_seq_midi_event snd_seq snd_pcm_oss snd_mixer_oss snd_ens1371 snd_rawmidi snd_seq_device snd_ac97_codec snd_pcm snd_page_alloc gameport snd_rtctimer snd_timer snd soundcore usbhid uhci_hcd usbcore via_rhine mii crc32 capability commoncap processor via686a w83781d i2c_sensor i2c_isa i2c_core msr cpuid ide_disk ext3 mbcache jbd via82cxxx ide_core

CPU:    0
EIP:    0060:[<c01b6f3e>]    Tainted: P      VLI
EFLAGS: 00010097   (2.6.10) 

EIP is at vsnprintf+0x30e/0x4f0
eax: 66666666 ebx: 0000000a ecx: 66666666 edx: fffffffe
esi: c03bfde3 edi: 00000000 ebp: c46d3f38 esp: c46d3efc
ds: 007b es: 007b ss: 0068
Process insmod (pid: 26344, threadinfo=c46d2000 task=c33f2140)

Stack: c46d3f0c c014fa0a c4245da0 00000001 c46d3f9c c0134526 d0a51000 0000000f 
       ffffffff ffffffff ffffffff c03c01df 00000400 00000246 c02d9660 c46d3f54 
       c01b7147 c03bfde0 00000400 d0a53038 c46d3f98 c03bfde0 c46d3f78 c011dda2 
Call Trace:
 [<c0106d0f>] show_stack+0x7f/0xa0
 [<c0106ea6>] show_registers+0x156/0x1d0
 [<c01070a8>] die+0xc8/0x150
 [<c0118410>] do_page_fault+0x440/0x707
 [<c01069a1>] error_code+0x2d/0x38
 [<c01b7147>] vscnprintf+0x27/0x40
 [<c011dda2>] vprintk+0x42/0x140
 [<c011dd58>] printk+0x18/0x20
 [<d0a5301c>] km_init_module+0x1c/0x20 [oops]
 [<c0134724>] sys_init_module+0x134/0x1c0
 [<c0105ecd>] sysenter_past_esp+0x52/0x71
Code: fd ff ff 83 cf 40 bb 10 00 00 00 eb 88 8b 45 14 8b

55 e8 83 45 14 04 8b 08 b8 6c 45 2b c0 81 f9 ff 0f 00 00 0f 46 c8 89 c8 eb 06 <80> 38 00 74 07 40 4a 83 fa ff 75 f4 29 c8 83 e7 10 89 c3 0f 85

#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/module.h>

MODULE_DESCRIPTION("buggy kernel module");
MODULE_LICENSE("GPL");

static int km_init_module(void)

{
    printk(KERN_DEBUG "%s init\n", 1.4);
    return 0;
}

static void km_exit_module(void)

{
    printk(KERN_DEBUG "km exit\n");
}

module_init(km_init_module);
module_exit(km_exit_module);

#1 lore raw
Quoted 9 lines · Paweł Sikora

Hi,

vsprintf.c- case 's':
vsprintf.c- s = va_arg(args, char *);
vsprintf.c- if ((unsigned long)s < PAGE_SIZE)
vsprintf.c- s = "<NULL>";
vsprintf.c-
vsprintf.c: OOPS! => len = strnlen(s, precision);

But it is the kernel module that's buggy. What's the problem?

#4 lore raw
In reply to Paweł Sikora
Quoted 8 lines

Hi,

static int km_init_module(void)

{
   printk(KERN_DEBUG "%s init\n", 1.4);
   return 0;
}

You do know that %s does not mix with 1.4?

Quoted 6 lines

vsprintf.c- case 's':
vsprintf.c- s = va_arg(args, char *);
vsprintf.c- if ((unsigned long)s < PAGE_SIZE)
vsprintf.c- s = "<NULL>";
vsprintf.c-
vsprintf.c: OOPS! => len = strnlen(s, precision);

Jan Engelhardt

Signature · 2 lines
Gesellschaft für Wissenschaftliche Datenverarbeitung
Am Fassberg, 37077 Göttingen, www.gwdg.de
#2 lore raw
In reply to Nick Piggin
Quoted 11 lines · Nick Piggin
Quoted 9 lines · Pawe Sikora

Hi,

vsprintf.c- case 's':
vsprintf.c- s = va_arg(args, char *);
vsprintf.c- if ((unsigned long)s < PAGE_SIZE)
vsprintf.c- s = "<NULL>";
vsprintf.c-
vsprintf.c: OOPS! => len = strnlen(s, precision);

Quoted 3 lines

But it is the kernel module that's buggy. What's the problem?

I think that block similar to setjmp/longjmp should be placed around such dangerous places to refues future oops. That's all.

#3 lore raw
Quoted 9 lines · Pawel Sikora
Quoted 8 lines · Nick Piggin
Quoted 6 lines · Pawe Sikora

vsprintf.c- case 's':
vsprintf.c- s = va_arg(args, char *);
vsprintf.c- if ((unsigned long)s < PAGE_SIZE)
vsprintf.c- s = "<NULL>";
vsprintf.c-
vsprintf.c: OOPS! => len = strnlen(s, precision);

Quoted 4 lines
Quoted 1 line

But it is the kernel module that's buggy. What's the problem?

I think that block similar to setjmp/longjmp should be placed around such dangerous places to refues future oops.

How do you want to find such bugs then?

Bernd

Signature · 3 lines
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services
#5 lore raw
In reply to Jan Engelhardt
Quoted 10 lines · you
Quoted 8 lines

Hi,

static int km_init_module(void)

{
   printk(KERN_DEBUG "%s init\n", 1.4);
   return 0;
}

You do know that %s does not mix with 1.4?

Yes, I known. I did it intentionally.
IMHO kernel should be more resistant to accidental programmers errors. Be secure, trust no one ;)
... and catch bugs with http://netlab.ru.is/exception/KernelExceptions.pdf

Signature · 3 lines
/* Copyright (C) 2003, SCO, Inc. This is valuable Intellectual Property. */

                           #define say(x) lie(x)
#6 lore raw
Quoted 5 lines
Quoted 1 line

You do know that %s does not mix with 1.4?

Yes, I known. I did it intentionally.
IMHO kernel should be more resistant to accidental programmers errors. Be secure, trust no one ;)

Well usually it should be. include/linux/kernel.h has the __attribute__(printf) stuff for the print[fk]* family.

Jan Engelhardt

Signature · 2 lines
Gesellschaft für Wissenschaftliche Datenverarbeitung
Am Fassberg, 37077 Göttingen, www.gwdg.de
#8 lore raw
In reply to Paweł Sikora
Quoted 10 lines · Paweł Sikora
Quoted 7 lines · you
Quoted 5 lines

static int km_init_module(void)

{
   printk(KERN_DEBUG "%s init\n", 1.4);
   return 0;
}

You do know that %s does not mix with 1.4?

Yes, I known. I did it intentionally.

"Doctor, it hurts when I do that."
"Then do not do it."

Quoted 1 line

IMHO kernel should be more resistant to accidental programmers errors.

What for? Simply fix them immediately.

Quoted 1 line

Be secure, trust no one ;)

ACK. Therefore the kernel oopses, rendering the machine useless for the moment and forces the programmer to look for the bug.

Quoted 1 line

... and catch bugs with http://netlab.ru.is/exception/KernelExceptions.pdf

What should happen afterwards?
Write a line to syslog which is probably ignored anyway?

Bernd

Signature · 3 lines
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services
#9 lore raw
Quoted 6 lines
Quoted 3 lines

Yes, I known. I did it intentionally.
IMHO kernel should be more resistant to accidental programmers errors. Be secure, trust no one ;)

ACK. Therefore the kernel oopses, rendering the machine useless for the moment and forces the programmer to look for the bug.

And thanks to the "stupidity" of the >> poster, the Debian Group found out that their box was h4x0r3d when the machine oopsed repeatedly. :-)

Jan Engelhardt

Signature · 2 lines
Gesellschaft fĂźr Wissenschaftliche Datenverarbeitung
Am Fassberg, 37077 GĂśttingen, www.gwdg.de
#7 lore raw
In reply to Jan Engelhardt
Quoted 3 lines · Jan Engelhardt
Quoted 3 lines
Quoted 1 line

You do know that %s does not mix with 1.4?

Yes, I known. I did it intentionally.

And you intentionally ignored the gcc warning... it's all yours.
I.e., a normal user couldn't load the kernel module.

Quoted 6 lines
Quoted 2 lines

IMHO kernel should be more resistant to accidental programmers errors. Be secure, trust no one ;)

Well usually it should be. include/linux/kernel.h has the __attribute__(printf) stuff for the print[fk]* family.

Signature · 1 line
~Randy