Skip to contentSkip to conversation

fbdev: fix compile of rivafb on __BIG_ENDIAN

DISCUSSION Benjamin Herrenschmidt 1 participant 1 message Nov 8, 2004 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 16 lines · Linux Kernel Mailing List

ChangeSet 1.2606, 2004/11/07 20:36:41-08:00, [email protected]

fbdev: fix compile of rivafb on __BIG_ENDIAN

Typo introduced by latest cleanups by Antonino

 riva_hw.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Nru a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c

drivers/video/riva/riva_hw.c line 2116

Quoted 6 lines
drivers/video/riva/riva_hw.c +1 -1
@@ -2112,7 +2112,7 @@
 #ifdef __BIG_ENDIAN
     /* turn on big endian register access */
     if(!(NV_RD32(chip->PMC, 0x00000004) & 0x01000001))
-    	NV_WR32(chip->PMC, 0x00000004], 0x01000001);
+    	NV_WR32(chip->PMC, 0x00000004, 0x01000001);
 #endif

Since the NV_* macros now use byteswapping readX/writeX, we probably want to remove the above bits completely... I suspect as-is, the driver no longer works on ppc, but then, I don't have nVidia HW to test any more.

Ben.