fbdev: fix compile of rivafb on __BIG_ENDIAN
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 16 lines · Linux Kernel Mailing List
ChangeSet 1.2606, 2004/11/07 20:36:41-08:00, [email protected]
fbdev: fix compile of rivafb on
__BIG_ENDIANTypo introduced by latest cleanups by Antonino
riva_hw.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)diff -Nru
a/drivers/video/riva/riva_hw.cb/drivers/video/riva/riva_hw.c
drivers/video/riva/riva_hw.c line 2116
Quoted 6 lines
drivers/video/riva/riva_hw.c +1
-1@@ -2112,7 +2112,7 @@#ifdef __BIG_ENDIAN/* turn on big endian register access */ if (!(NV_RD32 (chip->PMC,0x00000004 ) &0x01000001 )) - NV_WR32(chip->PMC, 0x00000004], 0x01000001); +NV_WR32 (chip->PMC,0x00000004 ,0x01000001 );#endif
Since the NV_* macros now use byteswapping readX/writeX, we probably want to remove the above bits completely... I suspect as-is, the driver no longer works on ppc, but then, I don't have nVidia HW to test any more.
Ben.