Skip to contentSkip to conversation

convert atmel_cs wireless driver to module_param

PATCH In review Stefan Sperling 2 participants 5 messages Nov 9, 2004 – Nov 20, 2004

Subsystems (3)
Kernel janitors Arm/Microchip (AT91) SoC support 802.11 (including cfg80211/NL80211)
lore
Share & tools
lore

Stefan Sperling

author
#0 lore raw

PATCH 1/1 convert atmel_cs wireless driver to module_param

Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.

net/wireless/atmel_cs.c renamed from net/wireless/atmel_cs.c.orig +3 -3
@@ -65,7 +65,7 @@
 */
 #ifdef PCMCIA_DEBUG
 static int pc_debug = PCMCIA_DEBUG;
-MODULE_PARM(pc_debug, "i");
+module_param(pc_debug, int, 0644);
 static char *version = "$Revision: 1.2 $";
 #define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args);
 #else

@@ -86,8 +86,8 @@ MODULE_AUTHOR("Simon Kelley");
 MODULE_DESCRIPTION("Support for Atmel at76c50x 802.11 wireless ethernet cards.");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("Atmel at76c50x PCMCIA cards");
-MODULE_PARM(irq_mask, "i");
-MODULE_PARM(irq_list, "1-4i");
+module_param(irq_mask, int, 0444);
+module_param_array(irq_list, int, NULL, 0444);
 
 /*====================================================================*/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#1 lore raw

PATCH 1/1 convert atmel_cs wireless driver to module_param

Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver. Obsoletes my previously posted patch for this driver.

net/wireless/atmel_cs.c renamed from net/wireless/atmel_cs.c.orig +3 -3
@@ -65,7 +65,7 @@
 */
 #ifdef PCMCIA_DEBUG
 static int pc_debug = PCMCIA_DEBUG;
-MODULE_PARM(pc_debug, "i");
+module_param(pc_debug, int, 0644);
 static char *version = "$Revision: 1.2 $";
 #define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args);
 #else

@@ -86,8 +86,8 @@ MODULE_AUTHOR("Simon Kelley");
 MODULE_DESCRIPTION("Support for Atmel at76c50x 802.11 wireless ethernet cards.");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("Atmel at76c50x PCMCIA cards");
-MODULE_PARM(irq_mask, "i");
-MODULE_PARM(irq_list, "1-4i");
+module_param(irq_mask, int, 0);
+module_param_array(irq_list, int, NULL, 0);
 
 /*====================================================================*/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Stefan Sperling

net/wireless/atmel_cs.c

Quoted 5 lines · Stefan Sperling

Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.

net/wireless/atmel_cs.c renamed from net/wireless/atmel_cs.c.orig +0 -0

please as described in Documentation/SubmittingPatches add one level. thanks :)

Quoted 10 lines
net/wireless/atmel_cs.c renamed from net/wireless/atmel_cs.c.orig +1 -1
@@ -65,7 +65,7 @@
 */
 #ifdef PCMCIA_DEBUG
 static int pc_debug = PCMCIA_DEBUG;
-MODULE_PARM(pc_debug, "i");
+module_param(pc_debug, int, 0644);
 static char *version = "$Revision: 1.2 $";
 #define DEBUG(n, args...) if (pc_debug>(n)) printk(KERN_DEBUG args);
 #else

net/wireless/atmel_cs.c MODULE_AUTHOR("Simon Kelley"); · line 90

Quoted 7 lines
net/wireless/atmel_cs.c renamed from net/wireless/atmel_cs.c.orig +2 -2
@@ -86,8 +86,8 @@ MODULE_AUTHOR("Simon Kelley");
 MODULE_DESCRIPTION("Support for Atmel at76c50x 802.11 wireless ethernet cards.");
 MODULE_LICENSE("GPL");
 MODULE_SUPPORTED_DEVICE("Atmel at76c50x PCMCIA cards");
-MODULE_PARM(irq_mask, "i");
-MODULE_PARM(irq_list, "1-4i");
+module_param(irq_mask, int, 0444);
+module_param_array(irq_list, int, NULL, 0444);

you send on the same driver multiple patches, is the newere one the better, what's their differences?

a++
maks

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

author
#3 lore raw
In reply to Stefan Sperling
Quoted 8 lines · maximilian attems

net/wireless/atmel_cs.c

Quoted 5 lines · Stefan Sperling

Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.

net/wireless/atmel_cs.c renamed from net/wireless/atmel_cs.c.orig +0 -0

please as described in Documentation/SubmittingPatches add one level. thanks :)

ouch!

Quoted 2 lines

you send on the same driver multiple patches, is the newere one the better, what's their differences?

sorry, my mistake. the newer one is better.
The difference is file permissions for /sys entries. The older patch exposed more variables as writable (0644), while the newer one should only make debug and verbosity flags writeable.

Unfortunately I had a hard drive crash last week and I thus cannot quickly re-send the patches with -p1.
So I'd suggest editing the diff directly, like so:
--- a/drivers/net/wireless/atmel_cs.c.orig 2004-11-09 20:40:21.974926616 +0100
+++ b/drivers/net/wireless/atmel_cs.c 2004-11-08 23:10:14.000000000 +0100

regards
stefan

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#4 lore raw
In reply to Stefan Sperling
Quoted 27 lines · On Sat, 20 Nov 2004, [email protected] wrote:
Quoted 8 lines · maximilian attems

net/wireless/atmel_cs.c

Quoted 5 lines · Stefan Sperling

Replaces MODULE_PARM with module_param calls in atmel_cs wireless driver.

net/wireless/atmel_cs.c renamed from net/wireless/atmel_cs.c.orig +0 -0

please as described in Documentation/SubmittingPatches add one level. thanks :)

ouch!

Quoted 2 lines

you send on the same driver multiple patches, is the newere one the better, what's their differences?

sorry, my mistake. the newer one is better.
The difference is file permissions for /sys entries. The older patch exposed more variables as writable (0644), while the newer one should only make debug and verbosity flags writeable.

Unfortunately I had a hard drive crash last week and I thus cannot quickly re-send the patches with -p1.
So I'd suggest editing the diff directly, like so:

drivers/net/wireless/atmel_cs.c renamed from drivers/net/wireless/atmel_cs.c.orig +0 -0
Quoted 3 lines

regards
stefan

shure the ones for next kjt are corrected,
but please keep it in mind for the next one.
please ping me if one of the patches in kjt is wrong or missing. kjt will be out in some hours hopefully. ;)

a++ maks

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors