Skip to contentSkip to conversation

more MODULE_PARM conversions

PATCH New Geert Uytterhoeven 2 participants 2 messages Nov 12, 2004 – Nov 13, 2004 1 message not in the archive SCSI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Geert Uytterhoeven

author
#1 lore raw
Quoted 25 lines · Linux Kernel Mailing List

ChangeSet 1.2156, 2004/11/11 13:50:06-08:00, [email protected]

[PATCH] more MODULE_PARM conversions

Convert MODULE_PARM() to module_param().

Signed-off-by Randy Dunlap <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
Signed-off-by Linus Torvalds <[email protected]>

diff -Nru a/drivers/scsi/mesh.c b/drivers/scsi/mesh.c

drivers/scsi/mesh.c +0 -8
@@ -60,22 +60,22 @@
 MODULE_DESCRIPTION("PowerMac MESH SCSI driver");
 MODULE_LICENSE("GPL");
 
-MODULE_PARM(sync_rate, "i");
-MODULE_PARM_DESC(sync_rate, "Synchronous rate (0..10, 0=async)");
-MODULE_PARM(sync_targets, "i");
-MODULE_PARM_DESC(sync_targets, "Bitmask of targets allowed to set synchronous");
-MODULE_PARM(resel_targets, "i");
-MODULE_PARM_DESC(resel_targets, "Bitmask of targets allowed to set disconnect");
-MODULE_PARM(debug_targets, "i");
-MODULE_PARM_DESC(debug_targets, "Bitmask of debugged targets");

drivers/scsi/mesh.c line 69

Quoted 10 lines
drivers/scsi/mesh.c +2 -3
-MODULE_PARM(init_reset_delay, "i");
-MODULE_PARM_DESC(init_reset_delay, "Initial bus reset delay (0=no reset)");
-
 static int sync_rate = CONFIG_SCSI_MESH_SYNC_RATE;
 static int sync_targets = 0xff;
 static int resel_targets = 0xff;
 static int debug_targets = 0;	/* print debug for these targets */
 static int init_reset_delay = CONFIG_SCSI_MESH_RESET_DELAY_MS;
+
+MODULE_PARM(sync_rate, int, 0);

^^^^^^^^^^^
Shouldn't these be module_parm?

drivers/scsi/mesh.c line 81

Quoted 12 lines
drivers/scsi/mesh.c +9 -0
+MODULE_PARM_DESC(sync_rate, "Synchronous rate (0..10, 0=async)");
+MODULE_PARM(sync_targets, int, 0);
+MODULE_PARM_DESC(sync_targets, "Bitmask of targets allowed to set synchronous");
+MODULE_PARM(resel_targets, int, 0);
+MODULE_PARM_DESC(resel_targets, "Bitmask of targets allowed to set disconnect");
+MODULE_PARM(debug_targets, int, 0644);
+MODULE_PARM_DESC(debug_targets, "Bitmask of debugged targets");
+MODULE_PARM(init_reset_delay, int, 0);
+MODULE_PARM_DESC(init_reset_delay, "Initial bus reset delay (0=no reset)");
 
 static int mesh_sync_period = 100;
 static int mesh_sync_offset = 0;

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw

PATCH 1/1 scsi/mesh: module_param corrections

Correct MODULE_PARM to module_param (somehow I changed the macro parameters but not the macro invocation).

Signed-off-by Randy Dunlap <[email protected]>

diffstat:=

 drivers/scsi/mesh.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
drivers/scsi/mesh.c renamed from drivers/scsi/mesh.c~mesh_modprm +5 -5
diff -Naurp ./drivers/scsi/mesh.c~mesh_modprm ./drivers/scsi/mesh.c
@@ -66,15 +66,15 @@ static int resel_targets = 0xff;
 static int debug_targets = 0;	/* print debug for these targets */
 static int init_reset_delay = CONFIG_SCSI_MESH_RESET_DELAY_MS;
 
-MODULE_PARM(sync_rate, int, 0);
+module_param(sync_rate, int, 0);
 MODULE_PARM_DESC(sync_rate, "Synchronous rate (0..10, 0=async)");
-MODULE_PARM(sync_targets, int, 0);
+module_param(sync_targets, int, 0);
 MODULE_PARM_DESC(sync_targets, "Bitmask of targets allowed to set synchronous");
-MODULE_PARM(resel_targets, int, 0);
+module_param(resel_targets, int, 0);
 MODULE_PARM_DESC(resel_targets, "Bitmask of targets allowed to set disconnect");
-MODULE_PARM(debug_targets, int, 0644);
+module_param(debug_targets, int, 0644);
 MODULE_PARM_DESC(debug_targets, "Bitmask of debugged targets");
-MODULE_PARM(init_reset_delay, int, 0);
+module_param(init_reset_delay, int, 0);
 MODULE_PARM_DESC(init_reset_delay, "Initial bus reset delay (0=no reset)");
 
 static int mesh_sync_period = 100;