md linear personality oops on boot with 2.6.10-rc1-mm4 and 2.6.10-rc1-mm5
Personalities : [linear] [raid0] [raid1] [raid5] [raid6] [raid10]
Event: 6
md3 : active raid1 hdc1[0] hda1[1]
497856 blocks [2/2] [UU]
md4 : active raid1 hdc3[0] hda3[1]
8008320 blocks [2/2] [UU]
md2 : active raid1 hdc5[0] hda5[1]
16008640 blocks [2/2] [UU]
md5 : active raid1 hdc6[0] hda6[1]
8008256 blocks [2/2] [UU]
md1 : active linear hdi1[2] hdc7[1] hda7[0]
85963392 blocks 64k rounding
md0 : active raid1 hdc8[0] hda8[1]
62645312 blocks [2/2] [UU]
unused devices: <none>
and the partition type on /dev/hdi1, /dev/hdc7 and /dev/hda7 is 0xfd, meaning the partition is automatically assembled during boot.
In 2.6.9-mm1, this works.
In 2.6.10-rc1-mm4 and 2.6.10-rc1-mm5, I get an oops during boot:
linear_run+0x20b
and the backtrace:
do_md_run__down_trylock
vprintkautorun_array
vprintkautorun_devicesautostart_arrays
Below are my .config and the part about md and /dev/md1 from dmesg from 2.6.9-mm1.
Kind regards,
Jurriaan
.config:
CONFIG_X86=yCONFIG_MMU=yCONFIG_UID16=yCONFIG_GENERIC_ISA_DMA=yCONFIG_GENERIC_IOMAP=yCONFIG_EXPERIMENTAL=yCONFIG_CLEAN_COMPILE=yCONFIG_LOCK_KERNEL=yCONFIG_LOCALVERSION=""CONFIG_SWAP=yCONFIG_SYSVIPC=yCONFIG_POSIX_MQUEUE=yCONFIG_SYSCTL=yCONFIG_AUDIT=yCONFIG_AUDITSYSCALL=yCONFIG_LOG_BUF_SHIFT=15CONFIG_HOTPLUG=yCONFIG_KOBJECT_UEVENT=yCONFIG_IKCONFIG=yCONFIG_KALLSYMS=yCONFIG_FUTEX=yCONFIG_EPOLL=yCONFIG_SHMEM=yCONFIG_CC_ALIGN_FUNCTIONS=0CONFIG_CC_ALIGN_LABELS=0CONFIG_CC_ALIGN_LOOPS=0CONFIG_CC_ALIGN_JUMPS=0CONFIG_MODULES=yCONFIG_OBSOLETE_MODPARM=yCONFIG_KMOD=yCONFIG_X86_PC=yCONFIG_MPENTIUM4=yCONFIG_X86_CMPXCHG=yCONFIG_X86_XADD=yCONFIG_X86_L1_CACHE_SHIFT=7CONFIG_RWSEM_XCHGADD_ALGORITHM=yCONFIG_GENERIC_CALIBRATE_DELAY=yCONFIG_X86_WP_WORKS_OK=yCONFIG_X86_INVLPG=yCONFIG_X86_BSWAP=yCONFIG_X86_POPAD_OK=yCONFIG_X86_GOOD_APIC=yCONFIG_X86_INTEL_USERCOPY=yCONFIG_X86_USE_PPRO_CHECKSUM=yCONFIG_HPET_TIMER=yCONFIG_HPET_EMULATE_RTC=yCONFIG_SMP=yCONFIG_NR_CPUS=2CONFIG_SCHED_SMT=yCONFIG_PREEMPT=yCONFIG_PREEMPT_BKL=yCONFIG_X86_LOCAL_APIC=yCONFIG_X86_IO_APIC=yCONFIG_X86_TSC=yCONFIG_X86_MCE=yCONFIG_X86_MCE_NONFATAL=yCONFIG_X86_MCE_P4THERMAL=yCONFIG_HIGHMEM4G=yCONFIG_HIGHMEM=yCONFIG_MTRR=yCONFIG_IRQBALANCE=yCONFIG_HAVE_DEC_LOCK=yCONFIG_KERN_PHYS_OFFSET=1CONFIG_PM=yCONFIG_ACPI=yCONFIG_ACPI_BOOT=yCONFIG_ACPI_INTERPRETER=yCONFIG_ACPI_SLEEP=yCONFIG_ACPI_SLEEP_PROC_FS=yCONFIG_ACPI_AC=yCONFIG_ACPI_BATTERY=yCONFIG_ACPI_BUTTON=yCONFIG_ACPI_VIDEO=mCONFIG_ACPI_FAN=yCONFIG_ACPI_PROCESSOR=yCONFIG_ACPI_THERMAL=yCONFIG_ACPI_THINKPAD=mCONFIG_ACPI_IBM=mCONFIG_ACPI_BLACKLIST_YEAR=0CONFIG_ACPI_BUS=yCONFIG_ACPI_EC=yCONFIG_ACPI_POWER=yCONFIG_ACPI_PCI=yCONFIG_ACPI_SYSTEM=yCONFIG_X86_PM_TIMER=yCONFIG_PCI=yCONFIG_PCI_GOANY=yCONFIG_PCI_BIOS=yCONFIG_PCI_DIRECT=yCONFIG_PCI_MMCONFIG=yCONFIG_PCI_LEGACY_PROC=yCONFIG_PCI_NAMES=yCONFIG_ISA=yCONFIG_PCMCIA_PROBE=yCONFIG_BINFMT_ELF=yCONFIG_BINFMT_MISC=yCONFIG_STANDALONE=yCONFIG_PREVENT_FIRMWARE_BUILD=yCONFIG_FW_LOADER=mCONFIG_PARPORT=yCONFIG_PARPORT_PC=yCONFIG_PARPORT_PC_CML1=yCONFIG_PNP=yCONFIG_PNPACPI=yCONFIG_BLK_DEV_FD=yCONFIG_INITRAMFS_SOURCE=""CONFIG_LBD=yCONFIG_IOSCHED_NOOP=yCONFIG_IOSCHED_AS=yCONFIG_IOSCHED_DEADLINE=yCONFIG_IOSCHED_CFQ=yCONFIG_IDE=yCONFIG_BLK_DEV_IDE=yCONFIG_BLK_DEV_IDEDISK=yCONFIG_IDEDISK_MULTI_MODE=yCONFIG_BLK_DEV_IDECD=yCONFIG_IDE_GENERIC=yCONFIG_BLK_DEV_IDEPCI=yCONFIG_IDEPCI_SHARE_IRQ=yCONFIG_BLK_DEV_GENERIC=yCONFIG_BLK_DEV_IDEDMA_PCI=yCONFIG_IDEDMA_PCI_AUTO=yCONFIG_BLK_DEV_HPT366=yCONFIG_BLK_DEV_PIIX=yCONFIG_BLK_DEV_IDEDMA=yCONFIG_IDEDMA_AUTO=yCONFIG_SCSI=yCONFIG_SCSI_PROC_FS=yCONFIG_BLK_DEV_SD=yCONFIG_BLK_DEV_SR=yCONFIG_CHR_DEV_SG=yCONFIG_SCSI_SPI_ATTRS=yCONFIG_SCSI_SYM53C8XX_2=yCONFIG_SCSI_SYM53C8XX_DMA_ADDRESSING_MODE=1CONFIG_SCSI_SYM53C8XX_DEFAULT_TAGS=16CONFIG_SCSI_SYM53C8XX_MAX_TAGS=64CONFIG_SCSI_QLA2XXX=yCONFIG_MD=yCONFIG_BLK_DEV_MD=yCONFIG_MD_LINEAR=yCONFIG_MD_RAID0=yCONFIG_MD_RAID1=yCONFIG_MD_RAID10=yCONFIG_MD_RAID5=yCONFIG_MD_RAID6=yCONFIG_IEEE1394=yCONFIG_IEEE1394_OHCI1394=yCONFIG_IEEE1394_RAWIO=yCONFIG_NET=yCONFIG_PACKET=yCONFIG_UNIX=yCONFIG_INET=yCONFIG_IP_MULTICAST=yCONFIG_IP_TCPDIAG=yCONFIG_NETFILTER=yCONFIG_IP_NF_CONNTRACK=yCONFIG_IP_NF_QUEUE=yCONFIG_IP_NF_IPTABLES=yCONFIG_IP_NF_MATCH_LIMIT=yCONFIG_IP_NF_MATCH_IPRANGE=yCONFIG_IP_NF_MATCH_MAC=yCONFIG_IP_NF_MATCH_PKTTYPE=yCONFIG_IP_NF_MATCH_MARK=yCONFIG_IP_NF_MATCH_MULTIPORT=yCONFIG_IP_NF_MATCH_TOS=yCONFIG_IP_NF_MATCH_RECENT=yCONFIG_IP_NF_MATCH_ECN=yCONFIG_IP_NF_MATCH_DSCP=yCONFIG_IP_NF_MATCH_AH_ESP=yCONFIG_IP_NF_MATCH_LENGTH=yCONFIG_IP_NF_MATCH_TTL=yCONFIG_IP_NF_MATCH_TCPMSS=yCONFIG_IP_NF_MATCH_HELPER=yCONFIG_IP_NF_MATCH_STATE=yCONFIG_IP_NF_MATCH_CONNTRACK=yCONFIG_IP_NF_MATCH_OWNER=yCONFIG_IP_NF_FILTER=yCONFIG_IP_NF_TARGET_REJECT=yCONFIG_IP_NF_TARGET_LOG=yCONFIG_IP_NF_TARGET_ULOG=yCONFIG_IP_NF_TARGET_TCPMSS=yCONFIG_IP_NF_NAT=yCONFIG_IP_NF_NAT_NEEDED=yCONFIG_IP_NF_TARGET_MASQUERADE=yCONFIG_IP_NF_TARGET_REDIRECT=yCONFIG_IP_NF_TARGET_NETMAP=yCONFIG_IP_NF_TARGET_SAME=yCONFIG_IP_NF_MANGLE=yCONFIG_IP_NF_TARGET_TOS=yCONFIG_IP_NF_TARGET_ECN=yCONFIG_IP_NF_TARGET_DSCP=yCONFIG_IP_NF_TARGET_MARK=yCONFIG_IP_NF_TARGET_CLASSIFY=yCONFIG_IP_NF_RAW=mCONFIG_IP_NF_TARGET_NOTRACK=mCONFIG_IP_NF_ARPTABLES=yCONFIG_IP_NF_ARPFILTER=yCONFIG_IP_NF_ARP_MANGLE=yCONFIG_NETDEVICES=yCONFIG_DUMMY=mCONFIG_NET_ETHERNET=yCONFIG_MII=yCONFIG_NET_PCI=yCONFIG_8139TOO=yCONFIG_E1000=yCONFIG_INPUT=yCONFIG_INPUT_MOUSEDEV=yCONFIG_INPUT_MOUSEDEV_PSAUX=yCONFIG_INPUT_MOUSEDEV_SCREEN_X=1600CONFIG_INPUT_MOUSEDEV_SCREEN_Y=1200CONFIG_SOUND_GAMEPORT=yCONFIG_SERIO=yCONFIG_SERIO_I8042=yCONFIG_SERIO_LIBPS2=yCONFIG_INPUT_KEYBOARD=yCONFIG_KEYBOARD_ATKBD=yCONFIG_INPUT_MOUSE=yCONFIG_MOUSE_PS2=yCONFIG_INPUT_MISC=yCONFIG_INPUT_PCSPKR=yCONFIG_VT=yCONFIG_VT_CONSOLE=yCONFIG_HW_CONSOLE=yCONFIG_SERIAL_8250=yCONFIG_SERIAL_8250_NR_UARTS=4CONFIG_SERIAL_CORE=yCONFIG_UNIX98_PTYS=yCONFIG_LEGACY_PTYS=yCONFIG_LEGACY_PTY_COUNT=256CONFIG_PRINTER=yCONFIG_HW_RANDOM=yCONFIG_RTC=yCONFIG_AGP=yCONFIG_AGP_INTEL=yCONFIG_DRM=yCONFIG_DRM_RADEON=yCONFIG_HPET=yCONFIG_HPET_MMAP=yCONFIG_HANGCHECK_TIMER=yCONFIG_I2C=yCONFIG_I2C_ALGOBIT=yCONFIG_FB=yCONFIG_FB_MODE_HELPERS=yCONFIG_FB_TILEBLITTING=yCONFIG_FB_RADEON=yCONFIG_FB_RADEON_I2C=yCONFIG_VGA_CONSOLE=yCONFIG_DUMMY_CONSOLE=yCONFIG_FRAMEBUFFER_CONSOLE=yCONFIG_FONTS=y
CONFIG_FONT_SUN12x22=yCONFIG_LOGO=yCONFIG_LOGO_LINUX_MONO=yCONFIG_LOGO_LINUX_VGA16=yCONFIG_LOGO_LINUX_CLUT224=yCONFIG_SOUND=yCONFIG_SND=yCONFIG_SND_TIMER=yCONFIG_SND_PCM=yCONFIG_SND_HWDEP=yCONFIG_SND_RAWMIDI=yCONFIG_SND_SEQUENCER=yCONFIG_SND_OSSEMUL=yCONFIG_SND_MIXER_OSS=yCONFIG_SND_PCM_OSS=yCONFIG_SND_SEQUENCER_OSS=yCONFIG_SND_RTCTIMER=yCONFIG_SND_VERBOSE_PRINTK=yCONFIG_SND_AC97_CODEC=yCONFIG_SND_EMU10K1=yCONFIG_SND_INTEL8X0=yCONFIG_USB=yCONFIG_USB_DEVICEFS=yCONFIG_USB_ARCH_HAS_HCD=yCONFIG_USB_ARCH_HAS_OHCI=yCONFIG_USB_EHCI_HCD=yCONFIG_USB_UHCI_HCD=yCONFIG_USB_PRINTER=yCONFIG_USB_STORAGE=yCONFIG_EXT2_FS=yCONFIG_EXT3_FS=yCONFIG_EXT3_FS_XATTR=yCONFIG_JBD=yCONFIG_FS_MBCACHE=yCONFIG_REISERFS_FS=yCONFIG_XFS_FS=yCONFIG_DNOTIFY=yCONFIG_ISO9660_FS=yCONFIG_JOLIET=yCONFIG_UDF_FS=yCONFIG_UDF_NLS=yCONFIG_FAT_FS=yCONFIG_MSDOS_FS=yCONFIG_VFAT_FS=yCONFIG_FAT_DEFAULT_CODEPAGE=437CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"CONFIG_PROC_FS=yCONFIG_PROC_KCORE=yCONFIG_SYSFS=yCONFIG_TMPFS=yCONFIG_RAMFS=yCONFIG_UFS_FS=yCONFIG_NFS_FS=yCONFIG_NFS_V3=yCONFIG_LOCKD=yCONFIG_LOCKD_V4=yCONFIG_SUNRPC=yCONFIG_MSDOS_PARTITION=yCONFIG_NLS=yCONFIG_NLS_DEFAULT="iso8859-1"CONFIG_NLS_CODEPAGE_437=yCONFIG_NLS_CODEPAGE_850=yCONFIG_NLS_ISO8859_1=yCONFIG_NLS_ISO8859_15=yCONFIG_NLS_UTF8=yCONFIG_EARLY_PRINTK=yCONFIG_X86_FIND_SMP_CONFIG=yCONFIG_X86_MPPARSE=yCONFIG_CRC32=yCONFIG_LIBCRC32C=mCONFIG_GENERIC_HARDIRQS=yCONFIG_GENERIC_IRQ_PROBE=yCONFIG_X86_SMP=yCONFIG_X86_HT=yCONFIG_X86_BIOS_REBOOT=yCONFIG_X86_TRAMPOLINE=yCONFIG_PC=y
relevant part of 2.6.9-mm1 dmesg:
Linux version 2.6.9-mm1 (jurriaan@middle) (gcc version 3.3.5 (Debian 1:3.3.5-2)) #6 SMP Tue Nov 9 12:23:44 CET 2004 2175MB HIGHMEM available.
896MB LOWMEM available.
md: linear personality registered as nr 1
md: raid0 personality registered as nr 2
md: raid1 personality registered as nr 3
md: raid10 personality registered as nr 9
md: raid5 personality registered as nr 4
raid5: automatically using best checksumming function: pIII_sse
pIII_sse : 3888.000 MB/sec
raid5: using function: pIII_sse (3888.000 MB/sec)
raid6: int32x1 867 MB/s
raid6: int32x2 1093 MB/s
raid6: int32x4 824 MB/s
raid6: int32x8 601 MB/s
raid6: mmxx1 2539 MB/s
raid6: mmxx2 3179 MB/s
raid6: sse1x1 1660 MB/s
raid6: sse1x2 2304 MB/s
raid6: sse2x1 2742 MB/s
raid6: sse2x2 3386 MB/s
raid6: using algorithm sse2x2 (3386 MB/s)
md: raid6 personality registered as nr 8
md: md driver 0.90.1 MAX_MD_DEVS=256, MD_SB_DISKS=27
Advanced Linux Sound Architecture Driver Version 1.0.6 (Sun Aug 15 07:17:53 2004 UTC).
md: Autodetecting RAID arrays. md: autorun ... md: considering hdi1 ... md: adding hdi1 ... md: hdc8 has different UUID to hdi1 md: adding hdc7 ... md: hdc6 has different UUID to hdi1 md: hdc5 has different UUID to hdi1 md: hdc3 has different UUID to hdi1 md: hdc1 has different UUID to hdi1 md: hda8 has different UUID to hdi1 md: adding hda7 ... md: hda6 has different UUID to hdi1 md: hda5 has different UUID to hdi1 md: hda3 has different UUID to hdi1 md: hda1 has different UUID to hdi1 md: created md1 md: bind<hda7> md: bind<hdc7> md: bind<hdi1> md: running: <hdi1><hdc7><hda7> md: ... autorun DONE. ReiserFS: md1: found reiserfs format "3.6" with standard journal ReiserFS: md1: using ordered data mode ReiserFS: md1: journal params: device md1, size 8192, journal first block 18, max trans len 1024, max batch 900, max commit age 30, max trans age 30 ReiserFS: md1: checking transaction log (md1) ReiserFS: md1: Using r5 hash to sort names
Signature · 5 lines
And the next time you consider complaining that running Lucid Emacs 19.05 via NFS from a remote Linux machine in Paraguay doesn't seem to get the background colors right, you'll know who to thank. Matt Welsh Debian (Unstable) GNU/Linux 2.6.9-mm1 2x6078 bogomips load 0.25
Quoted 6 lines · On Friday November 12, [email protected] wrote:
In 2.6.9-mm1, this works.
In 2.6.10-rc1-mm4 and 2.6.10-rc1-mm5, I get an oops during boot:
linear_run+0x20b
Thanks. Looks like an unsigned variable going negative:-( I made the mistake of only testing it with a linear array with all components the same size.
Please verify that this patch fixes it.
Thanks,
NeilBrown
###Comments for ChangeSet
Fix problem with unsigned variable going "negative" in linear.c
We replace 'size' by 'start'.
'start' means exactly the same as 'curr_offset - size', and the equivalence of the new code can be tested based on this. The difference is that 'start' will never be negative and so can fit in a 'sector_t' while 'size' could be negative.
Also make curr_offset sector_t, as it should have been.
### Diffstat output
./drivers/md/linear.c | 21 +++++++++++---------- 1 files changed, 11 insertions(+), 10 deletions(-)
drivers/md/linear.c renamed from drivers/md/linear.c~current~ +11 -10
@@ -117,8 +117,8 @@ static int linear_run (mddev_t *mddev)struct linear_hash *table;mdk_rdev_t *rdev;int i, nb_zone, cnt; -sector_t size; -unsigned int curr_offset; +sector_t start; +sector_t curr_offset;struct list_head *tmp; conf = kmalloc (sizeof (*conf) + mddev->raid_disks*sizeof(dev_info_t),
@@ -193,23 +193,24 @@ static int linear_run (mddev_t *mddev)* Here we generate the linear hash table */ table = conf->hash_table; - size =0 ; + start =0 ; curr_offset =0 ;for (i =0 ; i < cnt; i++) {dev_info_t *disk = conf->disks + i; +if (start > curr_offset) + table[-1 ].dev1 = disk; + disk->offset = curr_offset; curr_offset += disk->size; -if (size <0 ) { - table[-1 ].dev1 = disk; - } - size += disk->size; - -while (size>0 ) { +/* 'curr_offset' is the end of this disk +* 'start' is the start of table +*/ +while (start < curr_offset) { table->dev0 = disk; table->dev1 =NULL ; - size -= conf->smallest->size; + start += conf->smallest->size; table++; } }
From: Neil Brown <[email protected]>
Date: Sat, Nov 13, 2004 at 06:25:49PM +1100
Quoted 5 lines · On Friday November 12, [email protected] wrote:
Quoted 4 lines
In 2.6.9-mm1, this works.
In 2.6.10-rc1-mm4 and 2.6.10-rc1-mm5, I get an oops during boot:
Quoted 9 lines
Quoted 2 lines
linear_run+0x20bThanks. Looks like an unsigned variable going negative:-( I made the mistake of only testing it with a linear array with all components the same size.
Please verify that this patch fixes it.
Excellent, this makes 2.6.10-rc1-mm5 boot without any problems.
Kind regards,
Jurriaan
Signature · 3 lines
53 reasons why Janeway is better than Picard: (47) Kes. Troi. No contest. Debian (Unstable) GNU/Linux 2.6.9-mm1 2x6078 bogomips load 0.00
Quoted 5 lines · On Saturday November 13, [email protected] wrote:
Quoted 3 lines
Please verify that this patch fixes it.
Excellent, this makes 2.6.10-rc1-mm5 boot without any problems.
Thanks. I'll make sure it gets up-stream.
NeilBrown