- UML - redundant code removal from signal delivery

PATCH In review Jeff Dike 1 participant 1 message Nov 12, 2004 User-mode Linux (UML)

lore

Share & tools

lore

Jeff Dike

author

2004-11-12 23:56 UTC #0 lore raw

PATCH 4/11 - UML - redundant code removal from signal delivery

Quoted 1 line

From Bodo Stroesser - Change the do_signal interface to eliminate its

argument. Also, remove the calls from the system call handlers since they are redundant. In all cases, pending signals are checked for in the interrupt handler.
Temporarily, do_signal passes the current error to kern_do_signal.

Signed-off-by Jeff Dike <[email protected]>

arch/um/include/kern_util.h +1 -1

Index: 2.6.9/arch/um/include/kern_util.h
===================================================================
@@ -29,7 +29,7 @@
 extern void syscall_segv(int sig);
 extern int current_pid(void);
 extern unsigned long alloc_stack(int order, int atomic);
-extern int do_signal(int error);
+extern int do_signal(void);
 extern int is_stack_fault(unsigned long sp);
 extern unsigned long segv(unsigned long address, unsigned long ip, 
 			  int is_write, int is_user, void *sc);

arch/um/kernel/process_kern.c +1 -1

Index: 2.6.9/arch/um/kernel/process_kern.c
===================================================================
@@ -141,7 +141,7 @@
 void interrupt_end(void)
 {
 	if(need_resched()) schedule();
-	if(test_tsk_thread_flag(current, TIF_SIGPENDING)) do_signal(0);
+	if(test_tsk_thread_flag(current, TIF_SIGPENDING)) do_signal();
 }
 
 void release_thread(struct task_struct *task)

arch/um/kernel/signal_kern.c +3 -2

Index: 2.6.9/arch/um/kernel/signal_kern.c
===================================================================
@@ -159,9 +159,10 @@
 	return(0);
 }
 
-int do_signal(int error)
+int do_signal(void)
 {
-	return(kern_do_signal(&current->thread.regs, NULL, error));
+	return(kern_do_signal(&current->thread.regs, NULL, 
+			      PT_REGS_SYSCALL_RET(&current->thread.regs)));
 }
 
 /*

arch/um/kernel/skas/syscall_user.c +0 -7

Index: 2.6.9/arch/um/kernel/skas/syscall_user.c
===================================================================
@@ -10,10 +10,6 @@
 #include "sysdep/ptrace.h"
 #include "sysdep/sigcontext.h"
 
-/* XXX Bogus */
-#define ERESTARTSYS	512
-#define ERESTARTNOINTR	513
-#define ERESTARTNOHAND	514
 
 void handle_syscall(union uml_pt_regs *regs)
 {

@@ -26,9 +22,6 @@
 	result = execute_syscall(regs);
 
 	REGS_SET_SYSCALL_RETURN(regs->skas.regs, result);
-	if((result == -ERESTARTNOHAND) || (result == -ERESTARTSYS) || 
-	   (result == -ERESTARTNOINTR))
-		do_signal(result);
 
 	syscall_trace(regs, 1);
 	record_syscall_end(index, result);

arch/um/kernel/tt/syscall_user.c +0 -7

Index: 2.6.9/arch/um/kernel/tt/syscall_user.c
===================================================================
@@ -17,10 +17,6 @@
 #include "syscall_user.h"
 #include "tt.h"
 
-/* XXX Bogus */
-#define ERESTARTSYS	512
-#define ERESTARTNOINTR	513
-#define ERESTARTNOHAND	514
 
 void syscall_handler_tt(int sig, union uml_pt_regs *regs)
 {

@@ -42,9 +38,6 @@
 	UPT_SC(regs) = sc;
 
 	SC_SET_SYSCALL_RETURN(sc, result);
-	if((result == -ERESTARTNOHAND) || (result == -ERESTARTSYS) || 
-	   (result == -ERESTARTNOINTR))
-		do_signal(result);
 
 	syscall_trace(regs, 1);
 	record_syscall_end(index, result);