prevent loop infinite recursion
After "losetup /dev/loop0 /dev/loop0" I see a hard crash upon access of /dev/loop0. And of course the same happens after "losetup /dev/loop0 /dev/loop1; "losetup /dev/loop1 /dev/loop0"
Chris Spiegel reports a slightly different crash doing similar things.
The easiest fix is saying "don't do that then".
The patch below adds a (somewhat ugly) test for recursion. Maybe someone can think of a nicer version.
Andries
drivers/block/loop.c +25 -5
@@ -622,10 +622,17 @@ static int loop_change_fd(struct loop_dereturn error; } +static inline int is_loop_device (struct file *file) +{ +struct inode *i = file->f_mapping->host; + +return i &&S_ISBLK (i->i_mode) &&MAJOR (i->i_rdev) ==LOOP_MAJOR ; +} +static int loop_set_fd (struct loop_device *lo,struct file *lo_file,struct block_device *bdev,unsigned int arg) { -struct file *file; +struct file *file, *f;struct inode *inode;struct address_space *mapping;unsigned lo_blocksize;
@@ -636,15 +643,28 @@ static int loop_set_fd(struct loop_devic/* This is safe, since we have a reference from open(). */ __module_get (THIS_MODULE ); - error = -EBUSY ; -if (lo->lo_state != Lo_unbound) - goto out; - error = -EBADF ; file =fget (arg);if (!file) goto out; + error = -EBUSY ; +if (lo->lo_state != Lo_unbound) + goto out_putf; + +/* Avoid recursion */ + f = file; +while (is_loop_device (f)) { +struct loop_device *l; + +if (f->f_mapping->host == lo_file->f_mapping->host) + goto out_putf; + l = f->f_mapping->host->i_bdev->bd_disk->private_data; +if (l->lo_state == Lo_unbound) +break ; + f = l->lo_backing_file; + } + mapping = file->f_mapping; inode = mapping->host;