x86: only single-step into signal handlers if the tracer
Quoted 4 lines · Linux Kernel Mailing List
ChangeSet 1.2159, 2004/11/15 00:56:31-08:00, [email protected]
x86: only single-step into signal handlers if the tracer asked for it.
This reminds me of a problem I am seeing under recent -bk kernels.
Mozilla (FC2) will freeze (no screen redraws, etc.). 'ps xf' shows mozilla sleeping. If I strace the process, Mozilla will un-freeze and continue as expected.
Jeff
Quoted 8 lines · Jeff Garzik
Quoted 4 lines · Linux Kernel Mailing List
ChangeSet 1.2159, 2004/11/15 00:56:31-08:00, [email protected]
x86: only single-step into signal handlers if the tracer asked for it.
Quoted 6 lines
This reminds me of a problem I am seeing under recent -bk kernels.
Mozilla (FC2) will freeze (no screen redraws, etc.). 'ps xf' shows mozilla sleeping. If I strace the process, Mozilla will un-freeze and continue as expected.
Presumably the futex thing:
kernel/futex.c renamed from kernel/futex.c~revert-futex_wait-fix +24 -8
@@ -6,7 +6,7 @@* (C) Copyright 2003 Red Hat Inc, All Rights Reserved * * Removed page pinning, fix privately mapped COW pages and other cleanups -* (C) Copyright 2003 Jamie Lokier +* (C) Copyright 2003, 2004 Jamie Lokier * * Thanks to Ben LaHaise for yelling "hashed waitqueues" loudly * enough at me, Linus for the original (flawed) idea, Matthew
@@ -486,22 +486,37 @@ static int futex_wait(unsigned long uaddif (unlikely (ret !=0 )) goto out_release_sem; +queue_me (&q,-1 ,NULL ); +/* -* Access the page after the futex is queued. +* Access the page AFTER the futex is queued. +* Order is important: +* +* Userspace waiter: val = var; if (cond(val)) futex_wait(&var, val); +* Userspace waker: if (cond(var)) { var = new; futex_wake(&var); } +* +* The basic logical guarantee of a futex is that it blocks ONLY +* if cond(var) is known to be true at the time of blocking, for +* any cond. If we queued after testing *uaddr, that would open +* a race condition where we could block indefinitely with +* cond(var) false, which would violate the guarantee. +* +* A consequence is that futex_wait() can return zero and absorb +* a wakeup when *uaddr != val on entry to the syscall. This is +* rare, but normal. +* * We hold the mmap semaphore, so the mapping cannot have changed -* since we looked it up. +* since we looked it up in get_futex_key. */ if (get_user (curval, (int __user *)uaddr) !=0 ) { ret = -EFAULT ; - goto out_release_sem; + goto out_unqueue; }if (curval != val) { ret = -EWOULDBLOCK ; - goto out_release_sem; + goto out_unqueue; } -queue_me (&q,-1 ,NULL ); -/* * Now the futex is queued and we have checked the data, we * don't want to hold mmap_sem while we sleep.
@@ -542,10 +557,11 @@ static int futex_wait(unsigned long uaddWARN_ON (!signal_pending (current));return -EINTR ; + out_unqueue:/* If we were woken (and unqueued), we succeeded, whatever. */ if (!unqueue_me (&q)) ret =0 ; -out_release_sem: + out_release_sem:up_read (¤t->mm->mmap_sem);return ret; }
_
Quoted 9 lines
Quoted 6 lines
This reminds me of a problem I am seeing under recent -bk kernels.
Mozilla (FC2) will freeze (no screen redraws, etc.). 'ps xf' shows mozilla sleeping. If I strace the process, Mozilla will un-freeze and continue as expected.
Presumably the futex thing:
This patch seems to fix it for me, recently various programs have got stuck in pthread_condition_wait (this on x86-64).
When that happened I did gdb --pid and then 'continue' which made it wake up.
PATCH 1/1 x86_64: only single-step into signal handlers if the tracer asked for it
In reply to a message not in the archiveQuoted 4 lines · On Mon, Nov 15, 2004 at 08:56:31AM +0000, [email protected] wrote:
ChangeSet 1.2159, 2004/11/15 00:56:31-08:00, [email protected]
x86: only single-step into signal handlers if the tracer asked for it.
x86_64 looks to have the same issue. But I deferr to the experts (and hope this isn't a dupe).
arch/x86_64/kernel/signal.c +1 -1
@@ -325,7 +325,7 @@set_fs (USER_DS );if (regs->eflags &TF_MASK ) { -if (current->ptrace &PT_PTRACED ) { +if ((current->ptrace & (PT_PTRACED |PT_DTRACE )) == (PT_PTRACED |PT_DTRACE )) {ptrace_notify (SIGTRAP ); }else { regs->eflags &= ~TF_MASK ;
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
Re: [discuss] [PATCH 2.6.10-rc2] x86_64: only single-step into signal handlers if the tracer asked for it
Quoted 9 lines · Tom Rini
Quoted 4 lines · On Mon, Nov 15, 2004 at 08:56:31AM +0000, [email protected] wrote:
ChangeSet 1.2159, 2004/11/15 00:56:31-08:00, [email protected]
x86: only single-step into signal handlers if the tracer asked for it.
x86_64looks to have the same issue. But I deferr to the experts (and hope this isn't a dupe).
Looks good, thanks.
-Andi