Skip to contentSkip to conversation

SCSI initio.c: some cleanups

PATCH In review Adrian Bunk 2 participants 2 messages Nov 15, 2004 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SCSI initio.c: some cleanups

The patch below does the following cleanups:
- make some needlessly global code static
- remove the unused global function tul_pop_pend_scb

Please review and apply if it's correct.

diffstat output:

 drivers/scsi/initio.c |   79 +++++++++++++++---------------------------
 drivers/scsi/initio.h |   18 ---------
 2 files changed, 30 insertions(+), 67 deletions(-)
drivers/scsi/initio.h renamed from drivers/scsi/initio.h.old +0 -18
@@ -719,21 +719,3 @@
 #define SCSI_RESET_HOST_RESET 0x200
 #define SCSI_RESET_ACTION   0xff
 
-extern void init_i91uAdapter_table(void);
-extern int Addi91u_into_Adapter_table(WORD, WORD, BYTE, BYTE, BYTE);
-extern int tul_ReturnNumberOfAdapters(void);
-extern void get_tulipPCIConfig(HCS * pHCB, int iChannel_index);
-extern int init_tulip(HCS * pHCB, SCB * pSCB, int tul_num_scb, BYTE * pbBiosAdr, int reset_time);
-extern SCB *tul_alloc_scb(HCS * pHCB);
-extern int tul_abort_srb(HCS * pHCB, struct scsi_cmnd * pSRB);
-extern void tul_exec_scb(HCS * pHCB, SCB * pSCB);
-extern void tul_release_scb(HCS * pHCB, SCB * pSCB);
-extern void tul_stop_bm(HCS * pHCB);
-extern int tul_reset_scsi(HCS * pCurHcb, int seconds);
-extern int tul_isr(HCS * pHCB);
-extern int tul_reset(HCS * pHCB, struct scsi_cmnd * pSRB, unsigned char target);
-extern int tul_reset_scsi_bus(HCS * pCurHcb);
-extern int tul_device_reset(HCS * pCurHcb, struct scsi_cmnd *pSrb,
-		unsigned int target, unsigned int ResetFlags);
-				/* ---- EXTERNAL VARIABLES ---- */
-extern HCS tul_hcs[];
drivers/scsi/initio.c renamed from drivers/scsi/initio.c.old +30 -49

247 lines not on this page · raw message

#1 lore raw
Quoted 5 lines · Adrian Bunk

The patch below does the following cleanups:
- make some needlessly global code static
- remove the unused global function tul_pop_pend_scb

Please review and apply if it's correct.

Good idea, but this clashes with a function change I have pending. Please redo it in a week or two ;-)