Skip to contentSkip to conversation

SCSI ncr53c8xx.c: make a variable static

PATCH In review Adrian Bunk 2 participants 2 messages Nov 15, 2004 – Nov 16, 2004 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SCSI ncr53c8xx.c: make a variable static

The patch below makes a needlessly global variable static.

drivers/scsi/ncr53c8xx.c renamed from drivers/scsi/ncr53c8xx.c.old +1 -1
@@ -7738,7 +7738,7 @@
 **==========================================================
 */
 #ifdef	MODULE
-char *ncr53c8xx;	/* command line passed by insmod */
+static char *ncr53c8xx;		/* command line passed by insmod */
 module_param(ncr53c8xx, charp, 0);
 #endif
 
#1 lore raw
Quoted 1 line · Adrian Bunk

The patch below makes a needlessly global variable static.

This needs to be taken care of as part of a module_param conversion. Something similar to the sym2 conversion, I think ...

Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain