Skip to contentSkip to conversation

SCSI t128.c: remove an unused function

PATCH In review Adrian Bunk 2 participants 5 messages Nov 15, 2004 SCSI

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 SCSI t128.c: remove an unused function

The patch below removes the unused function t128_setup.

Please review whether it's correct.

diffstat output:

 drivers/scsi/t128.c |   28 ----------------------------
 1 files changed, 28 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>
drivers/scsi/t128.c renamed from drivers/scsi/t128.c.old +0 -28
@@ -154,34 +154,6 @@
 
 #define NO_SIGNATURES (sizeof (signatures) /  sizeof (struct signature))
 
-/*
- * Function : t128_setup(char *str, int *ints)
- *
- * Purpose : LILO command line initialization of the overrides array,
- * 
- * Inputs : str - unused, ints - array of integer parameters with ints[0]
- *	equal to the number of ints.
- *
- */
-
-void __init t128_setup(char *str, int *ints){
-    static int commandline_current = 0;
-    int i;
-    if (ints[0] != 2) 
-	printk("t128_setup : usage t128=address,irq\n");
-    else 
-	if (commandline_current < NO_OVERRIDES) {
-	    overrides[commandline_current].address = ints[1];
-	    overrides[commandline_current].irq = ints[2];
-	    for (i = 0; i < NO_BASES; ++i)
-		if (bases[i].address == ints[1]) {
-		    bases[i].noauto = 1;
-		    break;
-		}
-	    ++commandline_current;
-	}
-}
-
 /* 
  * Function : int t128_detect(Scsi_Host_Template * tpnt)
  *
#1 lore raw
Quoted 3 lines · Adrian Bunk

The patch below removes the unused function t128_setup.

Please review whether it's correct.

Its wrong. The fix is to make the setup function get called, IFF you can find anyone with a t128 any more

author
#2 lore raw
Quoted 7 lines · Alan Cox
Quoted 3 lines · Adrian Bunk

The patch below removes the unused function t128_setup.

Please review whether it's correct.

Its wrong. The fix is to make the setup function get called, IFF you can find anyone with a t128 any more

Ah, it seems your t128 fix which did this in 2.4.17-pre7 is (like your dtc cleanup in the same patch) among the fixes not yet forward-ported from 2.4 to 2.6 ...

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 4 lines · Adrian Bunk
Quoted 3 lines · Alan Cox
Quoted 2 lines · Adrian Bunk

The patch below removes the unused function t128_setup.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Please review whether it's correct.

Its wrong. The fix is to make the setup function get called, IFF you can find anyone with a t128 any more

Ah, it seems your t128 fix which did this in 2.4.17-pre7 is (like your dtc cleanup in the same patch) among the fixes not yet forward-ported from 2.4 to 2.6 ...

Yep. Those probably want propogating so they don't get lost. Not that 5380's work in 2.6 with all the scsi changes as far as I can tell

#4 lore raw
In reply to Adrian Bunk
Quoted 4 lines · Adrian Bunk
Quoted 3 lines · Alan Cox
Quoted 2 lines · Adrian Bunk

The patch below removes the unused function t128_setup.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Please review whether it's correct.

Its wrong. The fix is to make the setup function get called, IFF you can find anyone with a t128 any more

Ah, it seems your t128 fix which did this in 2.4.17-pre7 is (like your dtc cleanup in the same patch) among the fixes not yet forward-ported from 2.4 to 2.6 ...

Yep. Those probably want propogating so they don't get lost. Not that 5380's work in 2.6 with all the scsi changes as far as I can tell