Simple cleanups for powernow-k8
Hi!
This adds some comments where to get more data, puts in same name for same variable (numps vs. numpstates, vstable
vs. voltagestabilizationtime). Please apply,
Pavel
arch/i386/kernel/cpu/cpufreq/powernow-k8.c +8 -5
@@ -18,6 +18,9 @@* Processor information obtained from Chapter 9 (Power and Thermal Management) * of the "BIOS and Kernel Developer's Guide for the AMD Athlon 64 and AMD * Opteron Processors" available for download from www.amd.com +* +* Tables for specific CPUs can be infrerred from +* http://www.amd.com/us-en/assets/content_type/white_papers_and_tech_docs/30430.pdf */ #include <linux/kernel.h>
@@ -618,7 +612,7 @@return -ENODEV ; } - data->vstable = psb->voltagestabilizationtime; + data->vstable = psb->vstable;dprintk ("voltage stabilization time: %d(*20us)\n" , data->vstable);dprintk ("flags2: 0x%x\n" , psb->flags2);
@@ -632,9 +626,9 @@dprintk ("isochronous relief time: %d\n" , data->irt);dprintk ("maximum voltage step: %d - 0x%x\n" , mvs, data->vidmvs); -dprintk ("numpst: 0x%x\n" , psb->numpst); - cpst = psb->numpst; -if ((psb->cpuid ==0x00000fc0 ) || (psb->cpuid ==0x00000fe0 ) ){ +dprintk ("numpst: 0x%x\n" , psb->num_tables); + cpst = psb->num_tables; +if ((psb->cpuid ==0x00000fc0 ) || (psb->cpuid ==0x00000fe0 )) { thiscpuid =cpuid_eax (CPUID_PROCESSOR_SIGNATURE );if ((thiscpuid ==0x00000fc0 ) || (thiscpuid ==0x00000fe0 ) ) { cpst =1 ;
@@ -651,7 +645,7 @@dprintk ("maxvid: 0x%x\n" , psb->maxvid); maxvid = psb->maxvid; - data->numps = psb->numpstates; + data->numps = psb->numps;dprintk ("numpstates: 0x%x\n" , data->numps);return fill_powernow_table (data, (struct pst_s *)(psb+1 ), maxvid); }
arch/i386/kernel/cpu/cpufreq/powernow-k8.h +3 -3
@@ -152,14 +151,14 @@u8 signature[10 ];u8 tableversion;u8 flags1; -u16 voltagestabilizationtime; +u16 vstable;u8 flags2; -u8 numpst; +u8 num_tables;u32 cpuid;u8 plllocktime;u8 maxfid;u8 maxvid; -u8 numpstates; +u8 numps; };/* Pairs of fid/vid values are appended to the version 1.4 PSB table. */
Signature · 2 lines
People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!