nsp_cs bad queuecommand return

PATCH New Jens Axboe 1 participant 1 message Nov 19, 2004

Subsystems (2)

SCSI Ninja SCSI-3 / ninja SCSI-32Bi (16bit/CardBus) pcmcia SCSI host adapter driver

lore

Share & tools

lore

Jens Axboe

author

2004-11-19 09:02 UTC #0 lore raw

PATCH 1/1 nsp_cs bad queuecommand return

Hi,

Return 0 from queuecommand, if the command has been completed already.

Signed-off-by Jens Axboe <[email protected]>

===== drivers/scsi/pcmcia/nsp_cs.c 1.35 vs edited =====

drivers/scsi/pcmcia/nsp_cs.c +2 -2

@@ -226,7 +226,7 @@ static int nsp_queuecommand(Scsi_Cmnd *S
 		nsp_msg(KERN_DEBUG, "CurrentSC!=NULL this can't be happen");
 		SCpnt->result   = DID_BAD_TARGET << 16;
 		nsp_scsi_done(SCpnt);
-		return SCSI_MLQUEUE_HOST_BUSY;
+		return 0;
 	}
 
 #if 0

@@ -273,7 +273,7 @@ static int nsp_queuecommand(Scsi_Cmnd *S
 		nsp_dbg(NSP_DEBUG_QUEUECOMMAND, "selection fail");
 		SCpnt->result   = DID_BUS_BUSY << 16;
 		nsp_scsi_done(SCpnt);
-		return SCSI_MLQUEUE_DEVICE_BUSY;
+		return 0;
 	}

Signature · 1 line

Jens Axboe