setup_arg_pages can insert overlapping vma
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 12 lines · Martin Schwidefsky
In principle the patch is fine (it works and fixes a problem).
I tried to find out why s390 needs its own
setup_arg_pages32function. After I've compared the function with the commonsetup_arg_pagesseveral times and still couldn't find a reason for it I just removed the function. Still works fine. I think the reason to introducesetup_arg_pages32has been theSTACK_TOPdefine which needs to reflect the smaller address space for 31 bit programs. Since the change that madeTASK_SIZElook at theTIF_31BITbit to return the correct value for 31 and 64 bit programsSTACK_TOPis just correct as well.
Quoted 1 line
In short, just remove
setup_arg_pages32.
Tell me I'm being silly, Martin, but wouldn't it be wiser to stick with setup_arg_pages32 (with Nanhai's patch) for 2.6.10, then remove it after?
I'm cautious here because about six months ago I sent Andrew a patch which eliminated setup_arg_pages32 (or equiv) from the three arches, but the x86_64 one just wouldn't boot on Andrew's machine. Both hch and I spent hours staring at the code, neither of us could work out why.
Now, s390 may be greatly superior ;) but all the setup_arg_pages32 redefining is twisty weird stuff - good to be rid of it, but right now?
Hugh