Skip to contentSkip to conversation

typeof(dev->power.saved_state)

PATCH Russell King 1 participant 1 message Nov 28, 2004

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

arch/arm/common/sa1111.c: In function `sa1111_suspend':
arch/arm/common/sa1111.c:816: warning: assignment from incompatible pointer type

This is a rather annoying, and IMHO pointless warning. First
question: what is the reasoning for using an array of unsigned bytes here? Are we expecting to power manage devices which only have byte wide registers?

In reality, devices have half-word and word sized registers as well, which means that dev->power.saved_state actually points to device specific data (or even device driver specific data) for the device. As such, it makes far more sense for this to be a 'void *'.

I'd rather not go around the ARM kernel tree adding pointless casts to 'u8 *' and back again because the wrong type for this was picked in the structure definition, so here's a patch which changes this to void *.

include/linux/pm.h +1 -1
diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x *.orig -x *.rej orig/include/linux/pm.h linux/include/linux/pm.h
@@ -226,7 +226,7 @@ struct dev_pm_info {
 	u32			power_state;
 #ifdef	CONFIG_PM
 	u32			prev_state;
-	u8			* saved_state;
+	void			* saved_state;
 	atomic_t		pm_users;
 	struct device		* pm_parent;
 	struct list_head	entry;
Signature · 4 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core