Skip to contentSkip to conversation

don't recursively crash in die() on CHRP/PReP machines

PATCH New Jakub Bogusz 1 participant 1 message Dec 2, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 don't recursively crash in die() on CHRP/PReP machines

This patch avoids recursive crash (leading to kernel stack overflow) in die() on CHRP/PReP machines when CONFIG_PMAC_BACKLIGHT=y. set_backlight_* functions are placed in pmac section, which is discarded when _machine != _MACH_Pmac.

Should apply to latest 2.4.x and 2.6.x as well.

Signature · 1 line
Jakub Bogusz    http://cyber.cs.net.pl/~qboosh/
arch/ppc/kernel/traps.c renamed from arch/ppc/kernel/traps.c.orig +4 -2
@@ -88,8 +88,10 @@
 	console_verbose();
 	spin_lock_irq(&die_lock);
 #ifdef CONFIG_PMAC_BACKLIGHT
-	set_backlight_enable(1);
-	set_backlight_level(BACKLIGHT_MAX);
+	if (_machine == _MACH_Pmac) {
+		set_backlight_enable(1);
+		set_backlight_level(BACKLIGHT_MAX);
+	}
 #endif
 	printk("Oops: %s, sig: %ld\n", str, err);
 	show_regs(fp);