drivers/char/moxa.c: remove an unused function

PATCH In review Adrian Bunk 2 participants 3 messages Dec 5, 2004 – Dec 6, 2004 Char and misc drivers

lore

Share & tools

lore

Adrian Bunk

author

2004-12-05 17:05 UTC #0 lore raw

PATCH 1/1 drivers/char/moxa.c: remove an unused function

The patch below removes an unused global function.

diffstat output:

 drivers/char/moxa.c |   18 ------------------
 1 files changed, 18 deletions(-)

Signed-off-by Adrian Bunk <[email protected]>

drivers/char/moxa.c renamed from drivers/char/moxa.c.old +0 ~~-18~~

@@ -1765,7 +1765,6 @@
  *	2.  MoxaPortEnable(int port);					     *
  *	3.  MoxaPortDisable(int port);					     *
  *	4.  MoxaPortGetMaxBaud(int port);				     *
- *	5.  MoxaPortGetCurBaud(int port);				     *
  *	6.  MoxaPortSetBaud(int port, long baud);			     *
  *	7.  MoxaPortSetMode(int port, int databit, int stopbit, int parity); *
  *	8.  MoxaPortSetTermio(int port, unsigned char *termio); 	     *

@@ -1876,15 +1875,6 @@
  *                      38400/57600/115200 bps
  *
  *
- *      Function 9:     Get the current baud rate of this port.
- *      Syntax:
- *      long MoxaPortGetCurBaud(int port);
- *           int port           : port number (0 - 127)
- *
- *           return:    0       : this port is invalid
- *                      50 - 115200 bps
- *
- *
  *      Function 10:    Setting baud rate of this port.
  *      Syntax:
  *      long MoxaPortSetBaud(int port, long baud);

@@ -3093,14 +3083,6 @@
 	return (0);
 }
 
-long MoxaPortGetCurBaud(int port)
-{
-
-	if (moxaChkPort[port] == 0)
-		return (0);
-	return (moxaCurBaud[port]);
-}
-
 static void MoxaSetFifo(int port, int enable)
 {
 	void __iomem *ofsAddr = moxaTableAddr[port];

Tomasz Kłoczko

2004-12-05 20:16 UTC #1 lore raw

Quoted 13 lines · Adrian Bunk

The patch below removes an unused global function.
diffstat output:
drivers/char/moxa.c | 18 ------------------
1 files changed, 18 deletions(-)
Signed-off-by Adrian Bunk <[email protected]>

drivers/char/moxa.c line 1770

Quoted 7 lines

drivers/char/moxa.c renamed from drivers/char/moxa.c.old +0 -1

@@ -1765,7 +1765,6 @@
 *	2.  MoxaPortEnable(int port);					     *
 *	3.  MoxaPortDisable(int port);					     *
 *	4.  MoxaPortGetMaxBaud(int port);				     *
- *	5.  MoxaPortGetCurBaud(int port);				     *
 *	6.  MoxaPortSetBaud(int port, long baud);			     *
 *	7.  MoxaPortSetMode(int port, int databit, int stopbit, int parity); *
 *	8.  MoxaPortSetTermio(int port, unsigned char *termio); 	     *

[..]

Prabaly it will be good renumber this or make unnumbered (and all other comments with "Function <num>:" :)

[..]

Signature · 4 lines

-----------------------------------------------------------
*Ludzie nie mają problemów, tylko sobie sami je stwarzają*
-----------------------------------------------------------
Tomasz Kłoczko, sys adm @zie.pg.gda.pl|*e-mail: [email protected]*

Adrian Bunk

author

2004-12-06 00:54 UTC #2 lore raw

PATCH 1/1 drivers/char/moxa.c: #if 0 an unused function

Quoted 9 lines · Tomasz K?oczko

...
Quoted 8 lines
- * 5. MoxaPortGetCurBaud(int port);
*
* 6. MoxaPortSetBaud(int port, long baud);
*
* 7. MoxaPortSetMode(int port, int databit, int stopbit, int parity);
*
* 8. MoxaPortSetTermio(int port, unsigned char *termio);
*

Quoted 4 lines

[..]
Prabaly it will be good renumber this or make unnumbered (and all other comments with "Function <num>:" :)

Perhaps the following patch is the best solution:

diffstat output:

 drivers/char/moxa.c |    2 ++
 1 files changed, 2 insertions(+)

Signed-off-by Adrian Bunk <[email protected]>

drivers/char/moxa.c renamed from drivers/char/moxa.c.old +2 -0

@@ -3090,6 +3090,7 @@
 	return (0);
 }
 
+#if 0
 long MoxaPortGetCurBaud(int port)
 {

@@ -3097,6 +3098,7 @@
 		return (0);
 	return (moxaCurBaud[port]);
 }
+#endif  /*  0  */
 
 static void MoxaSetFifo(int port, int enable)
 {