Skip to contentSkip to conversation

mark QNX4FS_RW as BROKEN (fwd)

PATCH New Adrian Bunk 1 participant 1 message Dec 7, 2004 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mark QNX4FS_RW as BROKEN (fwd)

The patch forwarded below (already ACK'ed by Anders Larsen) still applies against 2.6.10-rc2-mm4.

Please apply.

----- Forwarded message from Adrian Bunk <[email protected]> -----

Date: Sat, 30 Oct 2004 23:22:50 +0200
From: Adrian Bunk <[email protected]>
To: Anders Larsen <[email protected]>
Cc: Al Viro <[email protected]>,
[email protected]
Subject: [2.6 patch] mark QNX4FS_RW as BROKEN

Quoted 10 lines · Anders Larsen
Quoted 2 lines · Adrian Bunk

The patch below does the following cleanups in the QNX4 fs:
- remove two unused global functions

If you remove any code inside the #ifdef CONFIG_QNX4FS_RW we might as well remove the option "config QNX4FS_RW" altogether. It's horribly broken, and I don't intend to fix it; while I was thinking about how to properly implement write-support, somebody else went away and did it. As that alternative seems to work well and is being actively maintained, I won't try to reinvent it.

OK, I understand why my patch wasn't good.

What about the following to mark it as BROKEN in the Kconfig file?

fs/Kconfig renamed from fs/Kconfig.old +1 -1
@@ -1353,7 +1353,7 @@
 
 config QNX4FS_RW
 	bool "QNX4FS write support (DANGEROUS)"
-	depends on QNX4FS_FS && EXPERIMENTAL
+	depends on QNX4FS_FS && EXPERIMENTAL && BROKEN
 	help
 	  Say Y if you want to test write support for QNX4 file systems.
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----