Skip to contentSkip to conversation

SX

PATCH In review Patrick van de Lageweg 2 participants 2 messages Dec 8, 2004 Char and misc drivers

lore
Share & tools
lore

Patrick van de Lageweg

author
#0 lore raw

PATCH 1/1 SX

Hi,

This patch converts all save_flags/restore_flags to the new spin_lick_irqsave/spin_unlock_irqrestore calls, as well as some other 2.6.X cleanups. This allows the "sx" driver to become SMP safe.

Signed-off-by Patrick vd Lageweg <[email protected]>
Signed-off-by Rogier Wolff <[email protected]>

Patrick

drivers/char/Kconfig +1 -1
diff -u -r linux-2.6.10-rc3-clean/drivers/char/Kconfig linux-2.6.10-rc3-sx/drivers/char/Kconfig
@@ -288,7 +288,7 @@
 
 config SX
 	tristate "Specialix SX (and SI) card support"
-	depends on SERIAL_NONSTANDARD && BROKEN_ON_SMP
+	depends on SERIAL_NONSTANDARD
 	help
 	  This is a driver for the SX and SI multiport serial cards.
 	  Please read the file <file:Documentation/sx.txt> for details.
drivers/char/sx.c +44 -21

210 lines not on this page · raw message

#1 lore raw

drivers/char/sx.c line 263

Quoted 10 lines
drivers/char/sx.c +3 -0
+/* Not used anymore??? - PVDL */
+#if 1
 #ifdef CONFIG_PCI
 static struct pci_device_id sx_pci_tbl[] = {
 	{ PCI_VENDOR_ID_SPECIALIX, PCI_DEVICE_ID_SPECIALIX_SX_XIO_IO8, PCI_ANY_ID, PCI_ANY_ID },

@@ -258,6 +260,7 @@
 };
 MODULE_DEVICE_TABLE(pci, sx_pci_tbl);
 #endif /* CONFIG_PCI */
+#endif

this is nessecary for installers to autoprobe the driver. But you should absolutely convert the driver to the pci_driver model so it's used inside the driver aswell.