Skip to contentSkip to conversation

patches: delete 75 unused files

KJ Domen Puncer 6 participants 11 messages Dec 8, 2004 – Dec 10, 2004 Kernel janitors

lore
Share & tools
lore

Domen Puncer

author
#0 lore raw

Hi.

Each of this filenames (ie dbg_stackcheck\.) was grepped trough whole source, finding no references.

Comments?

Patches can be found at:
http://coderock.org/kernel/janitor/unreferenced_files/

(4 files with 2004 copyright message are not included in .bz2 as there
are chances it's a uncomplete merge)

List of deleted files:
arch/alpha/lib/dbg_stackcheck.S arch/alpha/lib/dbg_stackkill.S arch/alpha/lib/stacktrace.c arch/arm/mach-iop3xx/iop331-mm.c arch/arm26/boot/compressed/hw-bse.c arch/m68k/apollo/dn_debug.c arch/m68k/sun3x/sun3x_ksyms.c arch/m68knommu/platform/68EZ328/ucsimm/crt0_himem.S arch/m68knommu/platform/68VZ328/ucdimm/crt0_himem.S arch/mips/arc/salone.c arch/mips/pmc-sierra/yosemite/ht-irq.c arch/ppc/kernel/find_name.c arch/ppc/syslib/ppc4xx_pm.c arch/ppc/syslib/ppc4xx_serial.c arch/ppc64/boot/no_initrd.c arch/sh64/lib/old-checksum.c arch/um/include/umn.h arch/x86_64/lib/old-checksum.c drivers/char/hp600_keyb.c drivers/char/rio/cdproto.h drivers/char/rsf16fmi.h drivers/media/dvb/frontends/dvb_dummy_fe.c drivers/media/dvb/frontends/sp887x_firm.h drivers/net/gt64240eth.h drivers/parport/parport_arc.c drivers/pci/hotplug/pcihp_skeleton.c drivers/pcmcia/au1000_generic.c drivers/pcmcia/au1000_pb1x00.c drivers/scsi/dpt/dpt_osdutil.h drivers/video/aty/xlinit.c drivers/video/riva/nv4ref.h fs/jffs2/histo.h
fs/jfs/jfs_defragfs.h include/asm-alpha/numnodes.h include/asm-arm/arch-epxa10db/mode_ctrl00.h include/asm-arm/arch-epxa10db/pld_conf00.h include/asm-arm/hardware/linkup-l1110.h include/asm-arm26/ian_char.h include/asm-m68k/atari_SCCserial.h include/asm-m68knommu/io_hw_swap.h include/asm-m68knommu/semp3.h include/asm-mips/gfx.h include/asm-mips/it8172/it8172_lpc.h include/asm-mips/mach-au1x00/au1100_mmc.h include/asm-mips/mipsprom.h include/asm-mips/ng1.h include/asm-mips/ng1hw.h include/asm-mips/riscos-syscall.h include/asm-parisc/bootdata.h include/asm-ppc64/iSeries/iSeries_fixup.h include/asm-um/arch-signal-i386.h include/asm-um/archparam-i386.h include/asm-um/archparam-ppc.h include/asm-um/module-generic.h include/asm-um/module-i386.h include/asm-um/processor-i386.h include/asm-um/processor-ppc.h include/asm-um/ptrace-i386.h include/asm-um/sigcontext-i386.h include/asm-um/sigcontext-ppc.h include/asm-um/system-i386.h include/asm-um/system-ppc.h include/linux/byteorder/pdp_endian.h include/linux/netfilter_ipv4/ip_logging.h include/linux/netfilter_ipv6/ip6_logging.h include/linux/umsdos_fs_i.h include/sound/soundmem.h net/sunrpc/auth_gss/gss_pseudoflavors.c net/sunrpc/auth_gss/sunrpcgss_syms.c sound/core/seq/oss/seq_oss_misc.c sound/oss/maestro_tables.h sound/pci/cs46xx/imgs/cwcemb80.h

Files with 2004 copyright message:
arch/mips/pci/ops-tx3927.c
include/asm-ia64/sn/fetchop.h
include/asm-ia64/sn/sndrv.h
include/asm-mips/mach-au1x00/au1xxx_psc.h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 1 line · Domen Puncer

drivers/pci/hotplug/pcihp_skeleton.c

This is a "skeleton" driver, and is in the tree to be used as an example for others who want to write a pci hotplug driver. It should stay.

Along those lines, how come you didn't include the usb-skeleton.c file in your list (it too should stay, but it isn't part of the build...)?

thanks,

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Domen Puncer
Quoted 8 lines · Greg KH
Quoted 1 line · Domen Puncer

drivers/pci/hotplug/pcihp_skeleton.c

This is a "skeleton" driver, and is in the tree to be used as an example for others who want to write a pci hotplug driver. It should stay.

Along those lines, how come you didn't include the usb-skeleton.c file in your list (it too should stay, but it isn't part of the build...)?

If I understand Domen's mail correctly, the mentioning of usb-skeleton in Documentation/DocBook/writing_usb_driver.tmpl and drivers/usb/input/xpad.c should be enough for preventing listing it.

Quoted 3 lines

thanks,

greg k-h

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#3 lore raw
In reply to Domen Puncer
Quoted 9 lines · Greg KH
Quoted 1 line · Domen Puncer

drivers/pci/hotplug/pcihp_skeleton.c

This is a "skeleton" driver, and is in the tree to be used as an example for others who want to write a pci hotplug driver. It should stay.

Along those lines, how come you didn't include the usb-skeleton.c file in your list (it too should stay, but it isn't part of the build...)?

Hi Greg,

Why these drivers are under the build tree and not in Documentation/ directory? Is it documented anywhere? I'm just curious.

Thanks,
Gustavo Franco -- <[email protected]>

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#4 lore raw
In reply to Domen Puncer
Quoted 7 lines · Gustavo Franco
Quoted 6 lines · Greg KH
Quoted 1 line · Domen Puncer

drivers/pci/hotplug/pcihp_skeleton.c

This is a "skeleton" driver, and is in the tree to be used as an example for others who want to write a pci hotplug driver. It should stay.

Quoted 6 lines
Quoted 3 lines

Along those lines, how come you didn't include the usb-skeleton.c file in your list (it too should stay, but it isn't part of the build...)?

Why these drivers are under the build tree and not in Documentation/ directory?

Because people don't expect to see source code in the Documentation/ directory :)

I don't really know, that's just the way these types of files have always been (look at drivers/net/pci-skeleton.c and drivers/net/isa-skeleton.c as where I got the idea to write usb-skeleton.c and pcihp_skeleton.c from.)

thanks,

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#5 lore raw
In reply to Domen Puncer
Quoted 15 lines · Greg KH
Quoted 7 lines · Gustavo Franco
Quoted 6 lines · Greg KH
Quoted 1 line · Domen Puncer

drivers/pci/hotplug/pcihp_skeleton.c

This is a "skeleton" driver, and is in the tree to be used as an example for others who want to write a pci hotplug driver. It should stay.

Quoted 6 lines
Quoted 3 lines

Along those lines, how come you didn't include the usb-skeleton.c file in your list (it too should stay, but it isn't part of the build...)?

Why these drivers are under the build tree and not in Documentation/ directory?

Quoted 7 lines

Because people don't expect to see source code in the Documentation/ directory :)

I don't really know, that's just the way these types of files have always been (look at drivers/net/pci-skeleton.c and drivers/net/isa-skeleton.c as where I got the idea to write usb-skeleton.c and pcihp_skeleton.c from.)

Yes, i see more skel stuff inside the tree and i think that it needs some discussion or at least don't use skeleton as part of a file name that will be compiled. AFAIK, we've some of them sitting at arch/m68k/..., but i can't check atm. What do you think?

--
Gustavo Franco -- <[email protected]>

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#6 lore raw
In reply to Domen Puncer
Quoted 29 lines · Gustavo Franco
Quoted 18 lines · Greg KH
Quoted 9 lines · Gustavo Franco
Quoted 7 lines · Greg KH
Quoted 1 line · Domen Puncer

drivers/pci/hotplug/pcihp_skeleton.c

This is a "skeleton" driver, and is in the tree to be used as an example for others who want to write a pci hotplug driver. It should stay.

Quoted 6 lines
Quoted 3 lines

Along those lines, how come you didn't include the usb-skeleton.c file in your list (it too should stay, but it isn't part of the build...)?

Why these drivers are under the build tree and not in Documentation/ directory?

Quoted 7 lines

Because people don't expect to see source code in the Documentation/ directory :)

I don't really know, that's just the way these types of files have always been (look at drivers/net/pci-skeleton.c and drivers/net/isa-skeleton.c as where I got the idea to write usb-skeleton.c and pcihp_skeleton.c from.)

Quoted 9 lines

Yes, i see more skel stuff inside the tree and i think that it needs some discussion or at least don't use skeleton as part of a file name that will be compiled. AFAIK, we've some of them sitting at arch/m68k/..., but i can't check atm. What do you think?

--
Gustavo Franco -- <[email protected]>

Why not make a Documentation/driver-skeletons.txt? I can write it, if everyone can point me in the direction of where all the skeleton and example files are.

Jim

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#7 lore raw
In reply to Domen Puncer
Quoted 11 lines · Jim Nelson

[...]

Quoted 6 lines

Yes, i see more skel stuff inside the tree and i think that it needs some discussion or at least don't use skeleton as part of a file name that will be compiled. AFAIK, we've some of them sitting at arch/m68k/..., but i can't check atm. What do you think?

Why not make a Documentation/driver-skeletons.txt? I can write it, if everyone can point me in the direction of where all the skeleton and example files are.

I agree, you're free to submit it but i've no idea if it will be accepted.

find . -name *skel* under the tree is a good guess, but you'll see some files that aren't skeletons. Actually, we can't say that all skeletons are with *skeleton* in their filenames, you can start the documention with these above and after that ask at lkml for more.

Hope that helps,
Gustavo Franco -- <[email protected]>

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#8 lore raw
In reply to Domen Puncer
Quoted 10 lines · Gustavo Franco
Quoted 9 lines · Jim Nelson

[...]

Quoted 6 lines

Yes, i see more skel stuff inside the tree and i think that it needs some discussion or at least don't use skeleton as part of a file name that will be compiled. AFAIK, we've some of them sitting at arch/m68k/..., but i can't check atm. What do you think?

Quoted 5 lines
Quoted 2 lines

Why not make a Documentation/driver-skeletons.txt? I can write it, if everyone can point me in the direction of where all the skeleton and example files are.

I agree, you're free to submit it but i've no idea if it will be accepted.

as greg already said, you won't expect code under Documentation. i won't push such patches.

please pick something usefull.

--
maks
kernel janitor http://janitor.kernelnewbies.org/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#10 lore raw
In reply to Domen Puncer
Quoted 8 lines · Gustavo Franco
Quoted 4 lines · Jim Nelson

Why not make a Documentation/driver-skeletons.txt? I can write it, if everyone can point me in the direction of where all the skeleton and example files are.

I agree, you're free to submit it but i've no idea if it will be accepted.

please forget my previous mail. misread end of the thread. ;-) that's a nice idea.

--
maks
kernel janitor http://janitor.kernelnewbies.org/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors