Skip to contentSkip to conversation

Compile 6xx specific code only for 6xx machines

PATCH In review [email protected] 3 participants 5 messages Dec 15, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Compile 6xx specific code only for 6xx machines

The 6xx specific mmu functions in arch/boot/common/util.S break the compile for other platforms. Compile them for 6xx only.

---
 util.S |    2 ++
 1 files changed, 2 insertions(+)

---

arch/ppc/boot/common/util.S +2 -0
Index: 2.6.10-rc3/arch/ppc/boot/common/util.S
===================================================================
@@ -27,6 +27,7 @@
 
 	.text
 
+#ifdef CONFIG_6xx
 	.globl	disable_6xx_mmu
 disable_6xx_mmu:
 	/* Establish default MSR value, exception prefix 0xFFF.
@@ -94,6 +95,7 @@
 	sync
 	isync
 	blr
+#endif
 
 	.globl	_setup_L2CR
 _setup_L2CR:
#1 lore raw
Quoted 2 lines · On Wed, Dec 15, 2004 at 03:21:43PM +0100, [email protected] wrote:

The 6xx specific mmu functions in arch/boot/common/util.S break the compile for other platforms. Compile them for 6xx only.

They, er, do? Can you please post a log? And what toolchain are you using? I'd make a quick guess that the binutils folks are being overly 'helpful' again, but perhaps I'm just jaded. :)

Signature · 2 lines
Tom Rini
http://gate.crashing.org/~trini/
#2 lore raw
Quoted 8 lines · Tom Rini
Quoted 2 lines · On Wed, Dec 15, 2004 at 03:21:43PM +0100, [email protected] wrote:

The 6xx specific mmu functions in arch/boot/common/util.S break the compile for other platforms. Compile them for 6xx only.

They, er, do? Can you please post a log? And what toolchain are you using? I'd make a quick guess that the binutils folks are being overly 'helpful' again, but perhaps I'm just jaded. :)

I'm compiling for 8540 (e500)

AS arch/ppc/boot/common/util.o
/home/tglx/work/repos/linux-ebrain/2.6.10- rc3/arch/ppc/boot/common/util.S: Assembler messages:
/home/tglx/work/repos/linux-ebrain/2.6.10- rc3/arch/ppc/boot/common/util.S:76: Error: Unrecognized opcode: `mtsrin' make[3]: *** [arch/ppc/boot/common/util.o] Error 1
make[2]: *** [arch/ppc/boot/common] Error 2
make[1]: *** [zImage] Error 2
make: *** [_all] Error 2

Toolchain is built with crosstool

binutils-2.15
gcc-3.4.2
glibc-2.3.3

tglx

#3 lore raw

One reason for this is that we dont have boot/common code for e500. Up=20=

to this point we've been using uImage's which causes code in=20 boot/common not to get built.

Maybe someone will be motivated to right e500/85xx boot/common code :)

- kumar

Quoted 8 lines · Thomas Gleixner
Quoted 3 lines · Tom Rini
Quoted 1 line · On Wed, Dec 15, 2004 at 03:21:43PM +0100, [email protected] wrote:

The 6xx specific mmu functions in arch/boot/common/util.S break=20

the compile for

Quoted 3 lines
Quoted 1 line

other platforms. Compile them for 6xx only.

They, er, do?=A0 Can you please post a log?=A0 And what toolchain =

are you

Quoted 32 lines
Quoted 1 line

using?=A0 I'd make a quick guess that the binutils folks are being=20=

overly

Quoted 1 line

'helpful' again, but perhaps I'm just jaded. :)

I'm compiling for 8540 (e500)

=A0 AS=A0=A0=A0=A0=A0 arch/ppc/boot/common/util.o /home/tglx/work/repos/linux-ebrain/2.6.10-
rc3/arch/ppc/boot/common/util.S: Assembler messages:
/home/tglx/work/repos/linux-ebrain/2.6.10- rc3/arch/ppc/boot/common/util.S:76: Error: Unrecognized opcode:=20
`mtsrin'
make[3]: *** [arch/ppc/boot/common/util.o] Error 1 make[2]: *** [arch/ppc/boot/common] Error 2
make[1]: *** [zImage] Error 2
make: *** [_all] Error 2

Toolchain is built with crosstool

binutils-2.15
gcc-3.4.2
glibc-2.3.3

tglx

_______________________________________________
Linuxppc-embedded mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-embedded

#4 lore raw
Quoted 7 lines · Kumar Gala

One reason for this is that we dont have boot/common code for e500. Up to this point we've been using uImage's which causes code in boot/common not to get built.

Maybe someone will be motivated to right e500/85xx boot/common code :)

- kumar

By adding this fix I can use the code in boot/simple. It works nice :)

tglx