tty/ldisc fix in 2.4
Hi,
I am unable to find a fix for the tty/ldisc problem (CAN-2004-0814) in 2.4.28 or 2.4 bitkeeper. I am wondering if anyone can either point me to what I am missing or indicate if there is a reason the patch hasn't been included. e.g. it slipped through the cracks.
The last I can find of it is here:
http://www.ussg.iu.edu/hypermail/linux/kernel/0410.3/1750.html
I am just curious, I am quite happy applying Jason Baron's patch.
Thanks
Signature · 1 line
Horms
Quoted 1 line · Horms
Hi,
Hi Horms,
Quoted 4 lines
I am unable to find a fix for the tty/ldisc problem (CAN-2004-0814) in 2.4.28 or 2.4 bitkeeper. I am wondering if anyone can either point me to what I am missing or indicate if there is a reason the patch hasn't been included. e.g. it slipped through the cracks.
The patch has not been included in 2.4.28 because it was too late in the v2.4.28 cycle for them to be included - they are quite intrusive.
And they there didnt seem stable at the time - but yes - we should now make an effort to include the locking fixes in 2.4.29.
Quoted 2 lines
The last I can find of it is here:
http://www.ussg.iu.edu/hypermail/linux/kernel/0410.3/1750.html
Jason, can you point us at your last patch ?
Has it been deployed in production ?
Quoted 1 line
I am just curious, I am quite happy applying Jason Baron's patch.
Sergey, I recall you seeing SieFS breakage due to Jason's patch - what was your finding on that?
Quoted 2 lines · Marcelo Tosatti
Sergey, I recall you seeing SieFS breakage due to Jason's patch - what was your finding on that?
I have found the bug - the call to tty->driver.set_termios in change_termios() was removed, therefore serial port speed was not set correctly. I sent patches fixing this to Jason Baron and to LKML:
http://lkml.org/lkml/2004/11/7/105
http://lkml.org/lkml/2004/11/7/106
http://lkml.org/lkml/2004/11/7/107
But I did not get any reply.
Quoted 13 lines · Marcelo Tosatti
Quoted 1 line · Horms
Hi,
Hi Horms,
Quoted 4 lines
I am unable to find a fix for the tty/ldisc problem (CAN-2004-0814) in 2.4.28 or 2.4 bitkeeper. I am wondering if anyone can either point me to what I am missing or indicate if there is a reason the patch hasn't been included. e.g. it slipped through the cracks.
The patch has not been included in 2.4.28 because it was too late in the v2.4.28 cycle for them to be included - they are quite intrusive.
Quoted 7 lines
And they there didnt seem stable at the time - but yes - we should now make an effort to include the locking fixes in 2.4.29.
Quoted 2 lines
The last I can find of it is here:
http://www.ussg.iu.edu/hypermail/linux/kernel/0410.3/1750.htmlJason, can you point us at your last patch ?
the latest one was the last one posted to this list plus Sergey's fixes. However, i think it was still missing some driver cleanups. I'll post an updated patch here.
Quoted 2 lines
Has it been deployed in production ?
It has resolved some real world customer issues.
thanks,
-Jason
Quoted 19 lines · Jason Baron
Quoted 16 lines · Marcelo Tosatti
Quoted 1 line · Horms
Hi,
Hi Horms,
Quoted 4 lines
I am unable to find a fix for the tty/ldisc problem (CAN-2004-0814) in 2.4.28 or 2.4 bitkeeper. I am wondering if anyone can either point me to what I am missing or indicate if there is a reason the patch hasn't been included. e.g. it slipped through the cracks.
The patch has not been included in 2.4.28 because it was too late in the v2.4.28 cycle for them to be included - they are quite intrusive.
And they there didnt seem stable at the time - but yes - we should now make an effort to include the locking fixes in 2.4.29.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
The last I can find of it is here:
http://www.ussg.iu.edu/hypermail/linux/kernel/0410.3/1750.htmlJason, can you point us at your last patch ?
the latest one was the last one posted to this list plus Sergey's fixes. However, i think it was still missing some driver cleanups. I'll post an updated patch here.
Hi,
thanks to all for the update. This definately answers my question. I will watch out for Jason's updated patch.
Signature · 1 line
Horms
Quoted 4 lines · Jason Baron
the latest one was the last one posted to this list plus Sergey's fixes. However, i think it was still missing some driver cleanups. I'll post an updated patch here.
updated patch at: http://people.redhat.com/~jbaron/tty/2.4-tty-V8.patch.
This patch adds 'tty_wakeup' and 'tty_ldisc_flush' calls to additional drivers. It also includes the two patches that Sergey previous posted.
thanks,
-Jason
Quoted 11 lines · Jason Baron
Quoted 4 lines · Jason Baron
the latest one was the last one posted to this list plus Sergey's fixes. However, i think it was still missing some driver cleanups. I'll post an updated patch here.
updated patch at: http://people.redhat.com/~jbaron/tty/2.4-tty-V8.patch.
This patch adds 'tty_wakeup' and 'tty_ldisc_flush' calls to additional drivers. It also includes the two patches that Sergey previous posted.
Its merged.
[PATCH] Backport v2.6 tty/ldisc locking fixes
I fail to credit you properly on the changelog, sorry:
I can't change a comment after it has been merged and I did a direct "bk import -tpatch".