bttv-cards.c: #if 0 function bttv_reset_audio
PATCH 1/1 bttv-cards.c: #if 0 function bttv_reset_audio
The function bttv_reset_audio in drivers/media/video/bttv-cards.c is completely unused.
drivers/media/video/bttv-cards.c renamed from drivers/media/video/bttv-cards.c.old +2 -1
@@ -2498,7 +2498,7 @@ }/* ----------------------------------------------------------------------- */ - +#if 0 void bttv_reset_audio (struct bttv *btv) {/*
@@ -2519,6 +2519,7 @@udelay (10 ); btwrite( 0, 0x058); } +#endif /* 0 */ /* initialization part one -- before registering i2c bus */ void __devinit bttv_init_card1 (struct bttv *btv)
Quoted 2 lines · Adrian Bunk
The function
bttv_reset_audioindrivers/media/video/bttv-cards.cis completely unused.
Looking at the comments and some old posts on the topic, are you sure this is the right fix? It is uncalled, and has been since 2.6.0 (oldest thing I have handy), but I think the actual bug may be that someone forget to call it, possibly from bttv_init_card2?
It would appear to not be needed because a reset clears it, but in the event that resume starts working, it might be useful.
Quoted 29 lines
Signed-off-by Adrian Bunk <[email protected]>drivers/media/video/bttv-cards.c renamed from drivers/media/video/bttv-cards.c.old +2
-2@@ -2498,7 +2498,7 @@ }/* ----------------------------------------------------------------------- */ - +#if 0 void bttv_reset_audio (struct bttv *btv) {/* @@ -2519,6 +2519,7 @@udelay (10 ); btwrite( 0, 0x058); } +#endif /* 0 */ /* initialization part one -- before registering i2c bus */ void __devinit bttv_init_card1 (struct bttv *btv) -To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 3 lines
-bill davidsen ([email protected]) "The secret to procrastination is to put things off until the last possible moment - but no longer" -me