Skip to contentSkip to conversation

Perfmon over-initialises its inodes

PATCH New Matthew Wilcox 1 participant 1 message Dec 19, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Perfmon over-initialises its inodes

i_sb and i_sock are both initialised by alloc_inode().

Index: linux/arch/ia64/kernel/perfmon.c =================================RCS file: /var/cvs/linux-2.6/arch/ia64/kernel/perfmon.c,v retrieving revision 1.20

arch/ia64/kernel/perfmon.c +0 -2
diff -u -p -r1.20 perfmon.c
@@ -2160,9 +2160,7 @@ pfm_alloc_fd(struct file **cfile)
 
 	DPRINT(("new inode ino=%ld @%p\n", inode->i_ino, inode));
 
-	inode->i_sb   = pfmfs_mnt->mnt_sb;
 	inode->i_mode = S_IFCHR|S_IRUGO;
-	inode->i_sock = 0;
 	inode->i_uid  = current->fsuid;
 	inode->i_gid  = current->fsgid;
 
Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain