2.6.x BUGs at boot time (APIC related)
Quoted 14 lines · vda
arch/i386/kernel/apic.c Thu Dec 23 08:54:13 2004 renamed from arch/i386/kernel/apic.c.old Mon Dec 20 14:13:59 2004 +3
-1@@ -1250,8 +1250,10 @@ */ int __init APIC_init_uniprocessor (void) { - if (enable_local_apic < 0) + if (enable_local_apic < 0) { clear_bit(X86_FEATURE_APIC, boot_cpu_data.x86_capability); + return -1; + } if (!smp_found_config && !cpu_has_apic) return -1;
Quoted 1 line · Mikael Pettersson
The early return just hides the real bug, whatever it is.
How about this:
- if (!smp_found_config && !cpu_has_apic)
+ if (!smp_found_config || !cpu_has_apic)
--
Please take it as a sign of my infinite respect for you, that I insist on you doing all the work.
-- Rusty Russell