Skip to contentSkip to conversation

2.6.10-ck1

DISCUSSION Chuck Ebbert 4 participants 4 messages Dec 25, 2004

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · Con Kolivas

.fix_noswap.diff
Build fix for config without swap

So 2.6.10 won't build without swap enabled?

This was a known problem; how did it get out the door without that fix?

--
Please take it as a sign of my infinite respect for you, that I insist on you doing all the work.
-- Rusty Russell

#1 lore raw
Quoted 6 lines · Chuck Ebbert
Quoted 2 lines · Con Kolivas

.fix_noswap.diff
Build fix for config without swap

So 2.6.10 won't build without swap enabled?

Built fine here.

Quoted 1 line

This was a known problem; how did it get out the door without that fix?

It looks like a different (and cleaner) fix was applied:
#define swap_token_default_timeout 0 when CONFIG_SWAP=n.

#2 lore raw
Quoted 12 lines · Sean Neakums
Quoted 7 lines · Chuck Ebbert
Quoted 2 lines · Con Kolivas

.fix_noswap.diff
Build fix for config without swap

So 2.6.10 won't build without swap enabled?

Quoted 8 lines

Built fine here.

Quoted 1 line

This was a known problem; how did it get out the door without that fix?

It looks like a different (and cleaner) fix was applied:
#define swap_token_default_timeout 0 when CONFIG_SWAP=n.

Ah thanks. I should have looked more carefully. I simply didn't see the fix Chuck posted. This should be better as Chuck's fix didn't disable the swap token (which still does stuff even with swap disabled).

Cheers,
Con