Skip to contentSkip to conversation

2.6.10 typo in include/linux/netfilter.h

DISCUSSION Nick Warne 6 participants 9 messages Dec 26, 2004

lore
Share & tools
lore

Nick Warne

author
#0 lore raw

Breaks the build.

Line 161

/* Call setsockopt() */
int nf_setsockopt(struct sock *sk, int pf, int optval, char __user *opt,

                  int len(;  <-------

Nick

Signature · 2 lines
"When you're chewing on life's gristle,
Don't grumble, Give a whistle..."
#1 lore raw
Quoted 7 lines · On Sun, 26 Dec 2004 09:17:38 +0000 Nick Warne <[email protected]> wrote:

Breaks the build.

Line 161

/* Call setsockopt() */
int nf_setsockopt(struct sock *sk, int pf, int optval, char __user *opt,

                  int len(;  <-------

That doesn't exist in the 2.6.10 sources. Something is up with the source tree you have. Lots of people would be complaining if this simplistic error were actually in the real 2.6.10 tree.

author
#2 lore raw
Quoted 10 lines · David S. Miller
Quoted 5 lines

Line 161

/* Call setsockopt() */
int nf_setsockopt(struct sock *sk, int pf, int optval, char __user *opt,

                  int len(;  <-------

That doesn't exist in the 2.6.10 sources. Something is up with the source tree you have. Lots of people would be complaining if this simplistic error were actually in the real 2.6.10 tree.

Yes, I thought strange, but this is the full tar.bz2 from kernel.org - I downloaded this morning about 2 hours ago.

http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.10.tar.bz2

Nick

Signature · 2 lines
"When you're chewing on life's gristle,
Don't grumble, Give a whistle..."
#3 lore raw
Quoted 11 lines · On Sun, 26 Dec 2004 10:59:57 +0000 Nick Warne <[email protected]> wrote:
Quoted 10 lines
Quoted 5 lines

Line 161

/* Call setsockopt() */
int nf_setsockopt(struct sock *sk, int pf, int optval, char __user *opt,

                  int len(;  <-------

That doesn't exist in the 2.6.10 sources. Something is up with the source tree you have. Lots of people would be complaining if this simplistic error were actually in the real 2.6.10 tree.

Quoted 5 lines

Yes, I thought strange, but this is the full tar.bz2 from kernel.org - I downloaded this morning about 2 hours ago.

http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.10.tar.bz2

I've just downloaded linux-2.6.10.tar.bz2 from kernel.org and there is no such error in netfilter.h:

/* Call setsockopt() */
int nf_setsockopt(struct sock *sk, int pf, int optval, char __user *opt,

                  int len);
Signature · 1 line
WBR, Roman
author
#4 lore raw

On Sunday 26 December 2004 11:20, Roman Ivanchukov wrote:

Strange - really strange. I was specific on that line as that is what GCC told me error was - and it was here.

Quoted 6 lines

I've just downloaded linux-2.6.10.tar.bz2 from kernel.org and there is no such error in netfilter.h:

/* Call setsockopt() */
int nf_setsockopt(struct sock *sk, int pf, int optval, char __user *opt,

                  int len);

I just DL'ed the tar.gz - that is OK.

The image build I done (using oldconfig) booted, but wouldn't mount disks, and a few other errors (like looking for modules - I don't build with modules).

What on earth could cause that then? Corrupt download? I would have thought nigh on impossible to get one or two errors like that if so?

Nick

Signature · 2 lines
"When you're chewing on life's gristle,
Don't grumble, Give a whistle..."
#5 lore raw
Quoted 14 lines · Nick Warne

On Sunday 26 December 2004 11:20, Roman Ivanchukov wrote:

Strange - really strange. I was specific on that line as that is what GCC told me error was - and it was here.

Quoted 6 lines

I've just downloaded linux-2.6.10.tar.bz2 from kernel.org and there is no such error in netfilter.h:

/* Call setsockopt() */
int nf_setsockopt(struct sock *sk, int pf, int optval, char __user *opt, int len);

I just DL'ed the tar.gz - that is OK.

Quoted 8 lines

The image build I done (using oldconfig) booted, but wouldn't mount disks, and a few other errors (like looking for modules - I don't build with modules).

What on earth could cause that then? Corrupt download? I would have thought nigh on impossible to get one or two errors like that if so?

Nick

Did you try checking the md5 of the tar.bz2?

Grahame

#6 lore raw
In reply to Nick Warne

* Nick Warne:

Quoted 6 lines

I just DL'ed the tar.gz - that is OK.

The image build I done (using oldconfig) booted, but wouldn't mount disks, and a few other errors (like looking for modules - I don't build with modules).

What on earth could cause that then? Corrupt download?

Probably that, or a flipped bit on your system.

You should download the .tar.bz2 file again and compare it to the first one.

Quoted 2 lines

I would have thought nigh on impossible to get one or two errors like that if so?

The TCP checksum does not guard against systematic bit errors in router memory chips, unfortunately.

#8 lore raw
In reply to Nick Warne
Quoted 12 lines · Nick Warne
Quoted 10 lines · David S. Miller
Quoted 5 lines

Line 161

/* Call setsockopt() */
int nf_setsockopt(struct sock *sk, int pf, int optval, char __user *opt, int len(; <-------

That doesn't exist in the 2.6.10 sources. Something is up with the source tree you have. Lots of people would be complaining if this simplistic error were actually in the real 2.6.10 tree.

Quoted 6 lines

Yes, I thought strange, but this is the full tar.bz2 from kernel.org
- I downloaded this morning about 2 hours ago.

http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.10.tar.bz2

Nick

I've had troubles of that nature when getting the .bz2's in a past life, so I normally get the .gz's and have had no reccurances of such little gotchas.

Signature · 8 lines
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
99.30% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attorneys please note, additions to this message
by Gene Heskett are:
Copyright 2004 by Maurice Eugene Heskett, all rights reserved.
#7 lore raw
In reply to Nick Warne
Quoted 18 lines · Nick Warne

On Sunday 26 December 2004 11:20, Roman Ivanchukov wrote:

Strange - really strange. I was specific on that line as that is what GCC told me error was - and it was here.

Quoted 6 lines

I've just downloaded linux-2.6.10.tar.bz2 from kernel.org and there is no such error in netfilter.h:

/* Call setsockopt() */
int nf_setsockopt(struct sock *sk, int pf, int optval, char __user *opt, int len);

I just DL'ed the tar.gz - that is OK.

The image build I done (using oldconfig) booted, but wouldn't mount disks, and a few other errors (like looking for modules - I don't build with modules).

Quoted 5 lines

What on earth could cause that then? Corrupt download? I would have thought nigh on impossible to get one or two errors like that if so?

Nick

The only problem I've had was the one I posted about earlier, something locked up amandad and this server didn't get backed up till I rebooted & reran amdump about 4ish this morning. That was after about 29 hrs uptime. It also claimed that a samba share I had mounted was busy(but that machine had been powered down for the night), and kpm was complaining about a lack of a dcopserver so it couldn't connect to the system to monitor anything. htop worked as expected though. Now I'm waiting for the other shoe to drop. If it does, I'll go back to Ingo's last realtime-preempt patch. That was solid, & had an 8 day uptime when I rebooted to 2.6.10.

Signature · 8 lines
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
99.30% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attorneys please note, additions to this message
by Gene Heskett are:
Copyright 2004 by Maurice Eugene Heskett, all rights reserved.