2.6.9 Use skb_padto() in drivers/net/8390.c
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 11 lines · Linux Kernel Mailing List
ChangeSet 1.1938.455.1, 2004/12/27 15:18:56-05:00, [email protected]
[PATCH] 2.6.9 Use
skb_padto()indrivers/net/8390.cThe 8390 driver had been fixed for leaking information in short packets prior to
skb_padto()existing. This change gets rid of the scratch area on the stack and makes it useskb_padto(). Thanks to Mark Smith for bringing this to my attention.Signed-off-by Paul Gortmaker <[email protected]>Signed-off-by Jeff Garzik <[email protected]>
This was done because it benchmarked materially faster than the skb_padto version you just reverted. Its only 64 bytes on the stack and its cached.
ie the old 8390 code was quite intentional and done because it commonly occurs on very old machines where clock count matters. Because of its commonness I actually hand optimised this one when I did the original fixes to avoid doing extra memory allocations.
Summary: Please revert.
Alan