net/3c505: replace schedule_timeout() with
Quoted 21 lines · Nishanth Aravamudan
Hi,
Description: Use
msleep()instead ofschedule_timeout()to guarantee the task delays as expected. There are no waitqueue events in the area, so an absolute sleep should be ok.Signed-off-by Nishanth Aravamudan <[email protected]>drivers/net/3c505.c +1
-2@@ -1327,8 +1327,7 @@ static int __init elp_sense(struct net_dif (orig_HSR &DIR ) {/* If HCR.DIR is up, we pull it down. HSR.DIR should follow. */ outb (0 , dev->base_addr +PORT_CONTROL ); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (30 *HZ /100 ); +msleep (300 );if (inb_status (addr) &DIR ) {if (elp_debug >0 )printk (notfound_msg,2 );
drivers/net/3c505.c static int __init elp_sense(struct net_d · line 1342
Quoted 9 lines
drivers/net/3c505.c +1
-2@@ -1337,8 +1336,7 @@ static int __init elp_sense(struct net_d }else {/* If HCR.DIR is down, we pull it up. HSR.DIR should follow. */ outb (DIR , dev->base_addr +PORT_CONTROL ); -set_current_state (TASK_UNINTERRUPTIBLE ); -schedule_timeout (30 *HZ /100 ); +msleep (300 );if (!(inb_status (addr) &DIR )) {if (elp_debug >0 )printk (notfound_msg,3 );
Please ignore this patch, as there is already a more correct one in the 2.6.10-kj patchset. Sorry for the noise.
Thanks,
Nish
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors