i386/power/cpu.c: remove three unused variables
PATCH 1/1 i386/power/cpu.c: remove three unused variables
The patch below removes three unused variables.
Please check whether this patch is correct, or whether the variables should have been used.
arch/i386/power/cpu.c renamed from arch/i386/power/cpu.c.old +1 -2
@@ -28,8 +28,7 @@static struct saved_context saved_context; -unsigned long saved_context_eax, saved_context_ebx; -unsigned long saved_context_ecx, saved_context_edx; +unsigned long saved_context_ebx;unsigned long saved_context_esp, saved_context_ebp;unsigned long saved_context_esi, saved_context_edi;unsigned long saved_context_eflags;
Hi!
Quoted 4 lines
The patch below removes three unused variables.
Please check whether this patch is correct, or whether the variables should have been used.
The patch is probably correct (assuming %eax, %ecx and %edx are caller-saved on i386. [Honza, please confirm... I do not know i386 calling convention by heart.]
Pavel
Signature · 2 lines
People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
Followup to: <[email protected]> By author: Pavel Machek <[email protected]> In newsgroup: linux.dev.kernel
Quoted 5 lines
Hi!
Quoted 2 lines
The patch below removes three unused variables.
Quoted 7 lines
Quoted 2 lines
Please check whether this patch is correct, or whether the variables should have been used.
The patch is probably correct (assuming %eax, %ecx and %edx are caller-saved on i386. [Honza, please confirm... I do not know i386 calling convention by heart.]
Pavel
%eax, %ecx, %edx, the FPU stack, the fsw, the XMM registers, and the arithmetric flags are caller-saved.
I *think* eflags.df is also caller-saved.
-hpa