Skip to contentSkip to conversation

ppc64/smp: replace schedule_timeout() with

PATCH Applied Nishanth Aravamudan 1 participant 1 message Jan 18, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 19/21 ppc64/smp: replace schedule_timeout() with

Hi,

Please consider applying.

Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. The current code is not incorrect; however using msleep() encourages using real time-unit sleeps and keeps the kernel consistent.

arch/ppc64/kernel/smp.c +1 -2
@@ -459,8 +459,7 @@ int __devinit __cpu_up(unsigned int cpu)
 		 * hotplug case.  Wait five seconds.
 		 */
 		for (c = 25; c && !cpu_callin_map[cpu]; c--) {
-			set_current_state(TASK_UNINTERRUPTIBLE);
-			schedule_timeout(HZ/5);
+			msleep(200);
 		}
 #endif
 

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors