Skip to contentSkip to conversation

i386: unexport do_settimeofday

RFC PATCH New Adrian Bunk 1 participant 2 messages Jan 20, 2005

Subsystems (10)
Arm (32-bit) MIPS s390 SuperH +6 more subsystems
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 i386: unexport do_settimeofday

I haven't found any modular usage of do_settimeofday in the kernel.

Is the patch below correct?

---

 arch/alpha/kernel/time.c     |    2 --
 arch/arm/kernel/time.c       |    2 --
 arch/arm26/kernel/time.c     |    2 --
 arch/cris/kernel/time.c      |    2 --
 arch/h8300/kernel/time.c     |    2 --
 arch/i386/kernel/time.c      |    2 --
 arch/m32r/kernel/time.c      |    2 --
 arch/m68k/kernel/time.c      |    2 --
 arch/m68knommu/kernel/time.c |    1 -
 arch/mips/dec/time.c         |    2 --
 arch/mips/kernel/time.c      |    2 --
 arch/parisc/kernel/time.c    |    1 -
 arch/ppc/kernel/time.c       |    2 --
 arch/ppc64/kernel/time.c     |    2 --
 arch/s390/kernel/time.c      |    2 --
 arch/sh/kernel/time.c        |    2 --
 arch/sparc/kernel/time.c     |    2 --
 arch/um/kernel/ksyms.c       |    1 -
 arch/v850/kernel/time.c      |    2 --
 arch/x86_64/kernel/time.c    |    2 --
 20 files changed, 37 deletions(-)
arch/i386/kernel/time.c renamed from arch/i386/kernel/time.c.old +0 -2
@@ -169,8 +169,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 static int set_rtc_mmss(unsigned long nowtime)
 {
 	int retval;
arch/arm/kernel/time.c renamed from arch/arm/kernel/time.c.old +0 -2
@@ -301,8 +301,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /**
  * save_time_delta - Save the offset between system time and RTC time
  * @delta: pointer to timespec to store delta
arch/sparc/kernel/time.c renamed from arch/sparc/kernel/time.c.old +0 -2
@@ -530,8 +530,6 @@
 	return ret;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 static int sbus_do_settimeofday(struct timespec *tv)
 {
 	time_t wtm_sec, sec = tv->tv_sec;
arch/ppc/kernel/time.c renamed from arch/ppc/kernel/time.c.old +0 -2
@@ -285,8 +285,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /* This function is only called on the boot processor */
 void __init time_init(void)
 {
arch/mips/dec/time.c renamed from arch/mips/dec/time.c.old +0 -2
@@ -189,8 +189,6 @@
 	CMOS_WRITE(RTC_REF_CLCK_32KHZ | (16 - LOG_2_HZ), RTC_REG_A);
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 void __init dec_timer_setup(struct irqaction *irq)
 {
 	setup_irq(dec_interrupt[DEC_IRQ_RTC], irq);
arch/mips/kernel/time.c renamed from arch/mips/kernel/time.c.old +0 -2
@@ -234,8 +234,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /*
  * Gettimeoffset routines.  These routines returns the time duration
  * since last timer interrupt in usecs.
arch/m68knommu/kernel/time.c renamed from arch/m68knommu/kernel/time.c.old +0 -1
@@ -195,4 +195,3 @@
 	return (unsigned long long)jiffies * (1000000000 / HZ);
 }
 
-EXPORT_SYMBOL(do_settimeofday);
arch/sh/kernel/time.c renamed from arch/sh/kernel/time.c.old +0 -2
@@ -254,8 +254,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /* last time the RTC clock got updated */
 static long last_rtc_update;
 
arch/cris/kernel/time.c renamed from arch/cris/kernel/time.c.old +0 -2
@@ -122,8 +122,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 
 /*
  * BUG: This routine does not handle hour overflow properly; it just
arch/arm26/kernel/time.c renamed from arch/arm26/kernel/time.c.old +0 -2
@@ -198,8 +198,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 static irqreturn_t timer_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 {
         do_timer(regs);
arch/m68k/kernel/time.c renamed from arch/m68k/kernel/time.c.old +0 -2
@@ -175,8 +175,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /*
  * Scheduler clock - returns current time in ns units.
  */
arch/alpha/kernel/time.c renamed from arch/alpha/kernel/time.c.old +0 -2
@@ -512,8 +512,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 
 /*
  * In order to set the CMOS clock precisely, set_rtc_mmss has to be
arch/ppc64/kernel/time.c renamed from arch/ppc64/kernel/time.c.old +0 -2
@@ -424,8 +424,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 void __init time_init(void)
 {
 	/* This function is only called on the boot processor */
arch/um/kernel/ksyms.c renamed from arch/um/kernel/ksyms.c.old +0 -1
@@ -95,7 +95,6 @@
 EXPORT_SYMBOL(dump_thread);
 
 EXPORT_SYMBOL(do_gettimeofday);
-EXPORT_SYMBOL(do_settimeofday);
 
 /* This is here because UML expands open to sys_open, not to a system
  * call instruction.
arch/parisc/kernel/time.c renamed from arch/parisc/kernel/time.c.old +0 -1
@@ -197,7 +197,6 @@
 	clock_was_set();
 	return 0;
 }
-EXPORT_SYMBOL(do_settimeofday);
 
 /*
  * XXX: We can do better than this.
arch/h8300/kernel/time.c renamed from arch/h8300/kernel/time.c.old +0 -2
@@ -125,8 +125,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 unsigned long long sched_clock(void)
 {
 	return (unsigned long long)jiffies * (1000000000 / HZ);
arch/m32r/kernel/time.c renamed from arch/m32r/kernel/time.c.old +0 -2
@@ -181,8 +181,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /*
  * In order to set the CMOS clock precisely, set_rtc_mmss has to be
  * called 500 ms after the second nowtime has started, because when
arch/x86_64/kernel/time.c renamed from arch/x86_64/kernel/time.c.old +0 -2
@@ -179,8 +179,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 unsigned long profile_pc(struct pt_regs *regs)
 {
 	unsigned long pc = instruction_pointer(regs);
arch/s390/kernel/time.c renamed from arch/s390/kernel/time.c.old +0 -2
@@ -148,8 +148,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 
 #ifdef CONFIG_PROFILING
 #define s390_do_profile(regs)	profile_tick(CPU_PROFILING, regs)
arch/v850/kernel/time.c renamed from arch/v850/kernel/time.c.old +0 -2
@@ -179,8 +179,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 static int timer_dev_id;
 static struct irqaction timer_irqaction = {
 	timer_interrupt,
#1 lore raw

RFC PATCH 1/1 unexport do_settimeofday

[ same patch with corrected subject ]

Is the patch below correct?

---

 arch/alpha/kernel/time.c     |    2 --
 arch/arm/kernel/time.c       |    2 --
 arch/arm26/kernel/time.c     |    2 --
 arch/cris/kernel/time.c      |    2 --
 arch/h8300/kernel/time.c     |    2 --
 arch/i386/kernel/time.c      |    2 --
 arch/m32r/kernel/time.c      |    2 --
 arch/m68k/kernel/time.c      |    2 --
 arch/m68knommu/kernel/time.c |    1 -
 arch/mips/dec/time.c         |    2 --
 arch/mips/kernel/time.c      |    2 --
 arch/parisc/kernel/time.c    |    1 -
 arch/ppc/kernel/time.c       |    2 --
 arch/ppc64/kernel/time.c     |    2 --
 arch/s390/kernel/time.c      |    2 --
 arch/sh/kernel/time.c        |    2 --
 arch/sparc/kernel/time.c     |    2 --
 arch/um/kernel/ksyms.c       |    1 -
 arch/v850/kernel/time.c      |    2 --
 arch/x86_64/kernel/time.c    |    2 --
 20 files changed, 37 deletions(-)
arch/i386/kernel/time.c renamed from arch/i386/kernel/time.c.old +0 -2
@@ -169,8 +169,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 static int set_rtc_mmss(unsigned long nowtime)
 {
 	int retval;
arch/arm/kernel/time.c renamed from arch/arm/kernel/time.c.old +0 -2
@@ -301,8 +301,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /**
  * save_time_delta - Save the offset between system time and RTC time
  * @delta: pointer to timespec to store delta
arch/sparc/kernel/time.c renamed from arch/sparc/kernel/time.c.old +0 -2
@@ -530,8 +530,6 @@
 	return ret;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 static int sbus_do_settimeofday(struct timespec *tv)
 {
 	time_t wtm_sec, sec = tv->tv_sec;
arch/ppc/kernel/time.c renamed from arch/ppc/kernel/time.c.old +0 -2
@@ -285,8 +285,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /* This function is only called on the boot processor */
 void __init time_init(void)
 {
arch/mips/dec/time.c renamed from arch/mips/dec/time.c.old +0 -2
@@ -189,8 +189,6 @@
 	CMOS_WRITE(RTC_REF_CLCK_32KHZ | (16 - LOG_2_HZ), RTC_REG_A);
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 void __init dec_timer_setup(struct irqaction *irq)
 {
 	setup_irq(dec_interrupt[DEC_IRQ_RTC], irq);
arch/mips/kernel/time.c renamed from arch/mips/kernel/time.c.old +0 -2
@@ -234,8 +234,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /*
  * Gettimeoffset routines.  These routines returns the time duration
  * since last timer interrupt in usecs.
arch/m68knommu/kernel/time.c renamed from arch/m68knommu/kernel/time.c.old +0 -1
@@ -195,4 +195,3 @@
 	return (unsigned long long)jiffies * (1000000000 / HZ);
 }
 
-EXPORT_SYMBOL(do_settimeofday);
arch/sh/kernel/time.c renamed from arch/sh/kernel/time.c.old +0 -2
@@ -254,8 +254,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /* last time the RTC clock got updated */
 static long last_rtc_update;
 
arch/cris/kernel/time.c renamed from arch/cris/kernel/time.c.old +0 -2
@@ -122,8 +122,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 
 /*
  * BUG: This routine does not handle hour overflow properly; it just
arch/arm26/kernel/time.c renamed from arch/arm26/kernel/time.c.old +0 -2
@@ -198,8 +198,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 static irqreturn_t timer_interrupt(int irq, void *dev_id, struct pt_regs *regs)
 {
         do_timer(regs);
arch/m68k/kernel/time.c renamed from arch/m68k/kernel/time.c.old +0 -2
@@ -175,8 +175,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /*
  * Scheduler clock - returns current time in ns units.
  */
arch/alpha/kernel/time.c renamed from arch/alpha/kernel/time.c.old +0 -2
@@ -512,8 +512,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 
 /*
  * In order to set the CMOS clock precisely, set_rtc_mmss has to be
arch/ppc64/kernel/time.c renamed from arch/ppc64/kernel/time.c.old +0 -2
@@ -424,8 +424,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 void __init time_init(void)
 {
 	/* This function is only called on the boot processor */
arch/um/kernel/ksyms.c renamed from arch/um/kernel/ksyms.c.old +0 -1
@@ -95,7 +95,6 @@
 EXPORT_SYMBOL(dump_thread);
 
 EXPORT_SYMBOL(do_gettimeofday);
-EXPORT_SYMBOL(do_settimeofday);
 
 /* This is here because UML expands open to sys_open, not to a system
  * call instruction.
arch/parisc/kernel/time.c renamed from arch/parisc/kernel/time.c.old +0 -1
@@ -197,7 +197,6 @@
 	clock_was_set();
 	return 0;
 }
-EXPORT_SYMBOL(do_settimeofday);
 
 /*
  * XXX: We can do better than this.
arch/h8300/kernel/time.c renamed from arch/h8300/kernel/time.c.old +0 -2
@@ -125,8 +125,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 unsigned long long sched_clock(void)
 {
 	return (unsigned long long)jiffies * (1000000000 / HZ);
arch/m32r/kernel/time.c renamed from arch/m32r/kernel/time.c.old +0 -2
@@ -181,8 +181,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 /*
  * In order to set the CMOS clock precisely, set_rtc_mmss has to be
  * called 500 ms after the second nowtime has started, because when
arch/x86_64/kernel/time.c renamed from arch/x86_64/kernel/time.c.old +0 -2
@@ -179,8 +179,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 unsigned long profile_pc(struct pt_regs *regs)
 {
 	unsigned long pc = instruction_pointer(regs);
arch/s390/kernel/time.c renamed from arch/s390/kernel/time.c.old +0 -2
@@ -148,8 +148,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 
 #ifdef CONFIG_PROFILING
 #define s390_do_profile(regs)	profile_tick(CPU_PROFILING, regs)
arch/v850/kernel/time.c renamed from arch/v850/kernel/time.c.old +0 -2
@@ -179,8 +179,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(do_settimeofday);
-
 static int timer_dev_id;
 static struct irqaction timer_irqaction = {
 	timer_interrupt,