fs/proc: replace schedule_timeout() with msleep()
PATCH 8/40 fs/proc: replace schedule_timeout() with msleep()
Hi,
Please consider applying.
Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. TASK_INTERRUPTIBLE is used in the current code, but signals are not checked for, so I believe the change to msleep() is appropriate.
Signed-off-by Nishanth Aravamudan <[email protected]>
fs/smbfs/proc.c +2 -2
@@ -23,6 +23,7 @@#include <linux/smb_fs.h> #include <linux/smbno.h> #include <linux/smb_mount.h> +#include <linux/delay.h> #include <net/sock.h>
@@ -2397,8 +2398,7 @@ smb_proc_readdir_long(struct file *filp,if (req->rq_rcls ==ERRSRV && req->rq_err == ERRerror) {/* a damn Win95 bug - sometimes it clags if you ask it too fast */ - current->state =TASK_INTERRUPTIBLE ; -schedule_timeout (HZ /5 ); +msleep (200 );continue ; }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors