Skip to contentSkip to conversation

sound/gus_reset: replace schedule_timeout() with

PATCH Applied Nishanth Aravamudan 1 participant 1 message Jan 21, 2005

Subsystems (2)
Sound Kernel janitors
lore
Share & tools
lore

Nishanth Aravamudan

author
#0 lore raw

PATCH 28/39 sound/gus_reset: replace schedule_timeout() with

Hi,

Please consider applying.

Description: Use msleep_interruptible() instead of custom wait code involving schedule_timeout() to guarantee the task delays as expected. This also removes a dependence on the value of HZ.

Signed-off-by Nishanth Aravamudan <[email protected]>
sound/isa/gus/gus_reset.c +1 -6
@@ -207,7 +207,6 @@ void snd_gf1_stop_voices(snd_gus_card_t 
 	unsigned long flags;
 	short i, ramp_ok;
 	unsigned short ramp_end;
-	long time;
 
 	if (!in_interrupt()) {	/* this can't be done in interrupt */
 		for (i = v_min, ramp_ok = 0; i <= v_max; i++) {

@@ -227,11 +226,7 @@ void snd_gf1_stop_voices(snd_gus_card_t 
 			}
 			spin_unlock_irqrestore(&gus->reg_lock, flags);
 		}
-		time = HZ / 20;
-		while (time > 0 && !signal_pending(current)) {
-			set_current_state(TASK_INTERRUPTIBLE);
-			time = schedule_timeout(time);
-		}
+		msleep_interruptible(50);
 	}
 	snd_gf1_clear_voices(gus, v_min, v_max);
 }

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors