Skip to contentSkip to conversation

random pt4: Create new rol32/ror32 bitops

PATCH Chuck Ebbert 2 participants 2 messages Jan 23, 2005 – Jan 24, 2005

lore
Share & tools
lore
#0 lore raw
Quoted 1 line · On Sat, 22 Jan 2005 at 20:13:24 -0800 Matt Mackall wrote:

So I think tweaks for x86 at least are unnecessary.

So the compiler looks for that specific sequence of instructions:

        (a << b) | (a >> (sizeof(a) * 8 - b)

and recognizes that it means rotation? Wow.

Chuck

#1 lore raw
Followup to:  <[email protected]>
By author:    Chuck Ebbert <[email protected]>
In newsgroup: linux.dev.kernel
Quoted 11 lines · On Sat, 22 Jan 2005 at 20:13:24 -0800 Matt Mackall wrote:
Quoted 2 lines

So I think tweaks for x86 at least are unnecessary.

So the compiler looks for that specific sequence of instructions:

        (a << b) | (a >> (sizeof(a) * 8 - b)

and recognizes that it means rotation? Wow.

You know, there is a LOT of instructions like that. x86 has a single instruction to do:

	a = b + (c << 3) + 3600;

(Assuming a, b and c are in eax, ebx, and ecx, respecively, the instruction is "leal 3600(%ebx,%ecx,3),%eax".)

The C compiler really needs to recognize these kinds of idioms, not just in the source, but that occur natually as a result of code generation and optimizations. The compiler lingo for this is "peephole optimization."

-hpa