Skip to contentSkip to conversation

Configure mangles hex values

PATCH Nick Pollitt 3 participants 5 messages Jan 24, 2005 – Jan 26, 2005

lore
Share & tools
lore
#0 lore raw

When doing a make oldconfig, the hex function strips the leading '0x' from hex values. The '0x' is needed in the final autoconf.h, and its absence causes the following problem.

If I start with a hex value in my config file like this:
CONFIG_LOWMEM_SIZE=0x40000000
When I run make oldconfig, it strips out the '0x' leaving this:
CONFIG_LOWMEM_SIZE=40000000
Then if I run make xconfig, this is not considered a valid hex value, so it replaces my value with the default:
CONFIG_LOWMEM_SIZE=0x20000000

The following patch removes the lines that strip the 0x from the hex value. It also checks the result for the leading 0x and inserts it if necessary.

Configure 2005-01-24 13:34:20.000000000 -0800 renamed from Configure.orig 2005-01-24 13:31:55.000000000 -0800 +8 -5
@@ -378,15 +378,18 @@
 function hex () {
  old=$(eval echo "\${$2}")
  def=${old:-$3}
- def=${def#*[x,X]}
  while :; do
    readln "$1 ($2) [$def] " "$def" "$old"
-   ans=${ans#*[x,X]}
-   if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
-     define_hex "$2" "0x$ans"
+   if expr "$ans" : '0x[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
+     define_hex "$2" "$ans"
      break
    else
-     help "$2"
+     if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
+       define_hex "$2" "0x$ans"
+       break
+     else
+       help "$2"
+     fi
    fi
  done
 }
#1 lore raw

Sorry about previous message.

The hex function in scripts/Configure strips the leading 0x from hex values. The 0x needs to be there in autoconf.h, and stripping it out causes the following problematic scenario:

If I start with a hex value in my config file like this:
CONFIG_LOWMEM_SIZE=0x40000000
and then run make oldconfig, it strips out the '0x' so I end up with this:
CONFIG_LOWMEM_SIZE=40000000
Then if I run make xconfig, it doesn't think this is a valid hex value, so it replaces my value with the default:
CONFIG_LOWMEM_SIZE=0x20000000

The following patch removes the lines that strip out 0x, and inserts the 0x if appropriate.

Configure 2005-01-24 13:34:20.000000000 -0800 renamed from Configure.orig 2005-01-24 13:31:55.000000000 -0800 +8 -5
@@ -378,15 +378,18 @@
 function hex () {
  old=$(eval echo "\${$2}")
  def=${old:-$3}
- def=${def#*[x,X]}
  while :; do
    readln "$1 ($2) [$def] " "$def" "$old"
-   ans=${ans#*[x,X]}
-   if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
-     define_hex "$2" "0x$ans"
+   if expr "$ans" : '0x[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
+     define_hex "$2" "$ans"
      break
    else
-     help "$2"
+     if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
+       define_hex "$2" "0x$ans"
+       break
+     else
+       help "$2"
+     fi
    fi
  done
 }
#2 lore raw

Hi Nick,

Curiosity: What was the reason for stripping the leading 0x?

Quoted 43 lines · Nick Pollitt

Sorry about previous message.

The hex function in scripts/Configure strips the leading 0x from hex values. The 0x needs to be there in autoconf.h, and stripping it out causes the following problematic scenario:

If I start with a hex value in my config file like this:
CONFIG_LOWMEM_SIZE=0x40000000
and then run make oldconfig, it strips out the '0x' so I end up with this:
CONFIG_LOWMEM_SIZE=40000000
Then if I run make xconfig, it doesn't think this is a valid hex value, so it replaces my value with the default:
CONFIG_LOWMEM_SIZE=0x20000000

The following patch removes the lines that strip out 0x, and inserts the 0x if appropriate.

Configure 2005-01-24 13:34:20.000000000 -0800 renamed from Configure.orig 2005-01-24 13:31:55.000000000 -0800 +8 -5
@@ -378,15 +378,18 @@
 function hex () {
  old=$(eval echo "\${$2}")
  def=${old:-$3}
- def=${def#*[x,X]}
  while :; do
    readln "$1 ($2) [$def] " "$def" "$old"
-   ans=${ans#*[x,X]}
-   if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
-     define_hex "$2" "0x$ans"
+   if expr "$ans" : '0x[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
+     define_hex "$2" "$ans"
      break
    else
-     help "$2"
+     if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
+       define_hex "$2" "0x$ans"
+       break
+     else
+       help "$2"
+     fi
    fi
  done
 }
#3 lore raw

Hello. I'm thinking that the 0x was stripped for purely cosmetic reasons rather than anything functional. I had originally thought that the readln function might need the formatting, but taking a closer look at it now I don't see any need.

Nick

Quoted 48 lines · Marcelo Tosatti

Hi Nick,

Curiosity: What was the reason for stripping the leading 0x?

Quoted 43 lines · Nick Pollitt

Sorry about previous message.

The hex function in scripts/Configure strips the leading 0x from hex values. The 0x needs to be there in autoconf.h, and stripping it out causes the following problematic scenario:

If I start with a hex value in my config file like this:
CONFIG_LOWMEM_SIZE=0x40000000
and then run make oldconfig, it strips out the '0x' so I end up with
this: CONFIG_LOWMEM_SIZE=40000000
Then if I run make xconfig, it doesn't think this is a valid hex value, so it replaces my value with the default:
CONFIG_LOWMEM_SIZE=0x20000000

The following patch removes the lines that strip out 0x, and inserts the 0x if appropriate.

Configure 2005-01-24 13:34:20.000000000 -0800 renamed from Configure.orig 2005-01-24 13:31:55.000000000 -0800 +8 -5
@@ -378,15 +378,18 @@
 function hex () {
  old=$(eval echo "\${$2}")
  def=${old:-$3}
- def=${def#*[x,X]}
  while :; do
    readln "$1 ($2) [$def] " "$def" "$old"
-   ans=${ans#*[x,X]}
-   if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
-     define_hex "$2" "0x$ans"
+   if expr "$ans" : '0x[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
+     define_hex "$2" "$ans"
      break
    else
-     help "$2"
+     if expr "$ans" : '[0-9a-fA-F][0-9a-fA-F]*$' > /dev/null; then
+       define_hex "$2" "0x$ans"
+       break
+     else
+       help "$2"
+     fi
    fi
  done
 }
#4 lore raw
Quoted 4 lines · Nick Pollitt

Hello. I'm thinking that the 0x was stripped for purely cosmetic reasons rather than anything functional. I had originally thought that the readln function might need the formatting, but taking a closer look at it now I don't see any need.

Agreed. Apply the patch.