net/lanstreamer: replace
Subsystems (2)
PATCH 27/34 net/lanstreamer: replace
Hi,
Please consider applying.
Description: Use wait_event_interruptible_timeout() instead of the deprecated interruptible_sleep_on_timeout(). Patch is compile-tested.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/net/tokenring/lanstreamer.c +20 -26
@@ -121,6 +121,7 @@#include <linux/spinlock.h> #include <linux/version.h> #include <linux/bitops.h> +#include <linux/wait.h> #include <net/checksum.h>
@@ -669,18 +670,16 @@ static int streamer_open(struct net_deviwritew (LISR_SRB_CMD , streamer_mmio +LISR_SUM );spin_unlock_irqrestore (&streamer_priv->streamer_lock, flags); -while (streamer_priv->srb_queued) { -interruptible_sleep_on_timeout (&streamer_priv->srb_wait,5 *HZ ); -if (signal_pending (current)) { -printk (KERN_WARNING "%s: SRB timed out.\n" , dev->name); -printk (KERN_WARNING "SISR=%x MISR=%x, LISR=%x\n" , -readw (streamer_mmio +SISR ), -readw (streamer_mmio +MISR_RUM ), -readw (streamer_mmio +LISR )); - streamer_priv->srb_queued =0 ; -break ; - } - } +wait_event_interruptible_timeout (streamer_priv->srb_wait, + !streamer_priv->srb_queued,5 *HZ ); +if (signal_pending (current)) { +printk (KERN_WARNING "%s: SRB timed out.\n" , dev->name); +printk (KERN_WARNING "SISR=%x MISR=%x, LISR=%x\n" , +readw (streamer_mmio +SISR ), +readw (streamer_mmio +MISR_RUM ), +readw (streamer_mmio +LISR )); + streamer_priv->srb_queued =0 ; + }#if STREAMER_DEBUG printk ("SISR_MASK: %x\n" ,readw (streamer_mmio +SISR_MASK ));
@@ -1223,20 +1222,15 @@ static int streamer_close(struct net_devspin_unlock_irqrestore (&streamer_priv->streamer_lock, flags); -while (streamer_priv->srb_queued) - { -interruptible_sleep_on_timeout (&streamer_priv->srb_wait, - jiffies +60 *HZ ); -if (signal_pending (current)) - { -printk (KERN_WARNING "%s: SRB timed out.\n" , dev->name); -printk (KERN_WARNING "SISR=%x MISR=%x LISR=%x\n" , -readw (streamer_mmio +SISR ), -readw (streamer_mmio +MISR_RUM ), -readw (streamer_mmio +LISR )); - streamer_priv->srb_queued =0 ; -break ; - } +wait_event_interruptible_timeout (streamer_priv->srb_wait, + !streamer_priv->srb_queued,60 *HZ ); +if (signal_pending (current)) { +printk (KERN_WARNING "%s: SRB timed out.\n" , dev->name); +printk (KERN_WARNING "SISR=%x MISR=%x LISR=%x\n" , +readw (streamer_mmio +SISR ), +readw (streamer_mmio +MISR_RUM ), +readw (streamer_mmio +LISR )); + streamer_priv->srb_queued =0 ; } streamer_priv->rx_ring_last_received = (streamer_priv->rx_ring_last_received +1 ) & (STREAMER_RX_RING_SIZE -1 );
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors