Skip to contentSkip to conversation

patch to fix recent percpu mca changes which broke CPU hotplug

DISCUSSION Ashok Raj 2 participants 2 messages Jan 28, 2005

lore
Share & tools
lore

Ashok Raj

author
#0 lore raw

Hi Tony

Recent mca percpu changes broke a cpu being brought up after initial boot which is required for cpu hotplug.

trivial patch

Signature · 29 lines
Cheers,
Ashok Raj



---

Signed-off-by: Ashok Raj <[email protected]>

Tried booting with maxcpus=1 and then try to bring the other cpu's up
by echoing to online file.
---

 linux-ia64-release-2.6.11-araj/arch/ia64/kernel/mca.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/ia64/kernel/mca.c~fix_mca_init arch/ia64/kernel/mca.c
--- linux-ia64-release-2.6.11/arch/ia64/kernel/mca.c~fix_mca_init	2005-01-28 12:11:24.627261951 -0800
+++ linux-ia64-release-2.6.11-araj/arch/ia64/kernel/mca.c	2005-01-28 12:24:52.657525490 -0800
@@ -1204,7 +1204,7 @@ static struct irqaction mca_cpep_irqacti
 
 /* Do per-CPU MCA-related initialization.  */
 
-void __init
+void __devinit
 ia64_mca_cpu_init(void *cpu_data)
 {
 	void *pal_vaddr;
_
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line · Ashok Raj

Ashok> Hi Tony Recent mca percpu changes broke a cpu being brought Ashok> up after initial boot which is required for cpu hotplug.

Argh, I _briefly_ wondered about, but forgot about it before checking on it. Sorry about that.

	--david