usb/kaweth: use wait_event_timeout()
Quoted 7 lines · Nishanth Aravamudan
Hi,
Please consider applying.
Description: Use
wait_event_timeout()instead of custom wait-queue code. Remove now unused variables. I changed the code to only add to the wait-queue if necessary, but I'm not sure if this is correct.
Please at least compile your patches to make sure they build. This one does not :(
greg k-h
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 11 lines · Greg KH
Quoted 7 lines · Nishanth Aravamudan
Hi,
Please consider applying.
Description: Use
wait_event_timeout()instead of custom wait-queue code. Remove now unused variables. I changed the code to only add to the wait-queue if necessary, but I'm not sure if this is correct.Please at least compile your patches to make sure they build. This one does not :(
I'm not seeing a build error here; what errors are coming up for you?
Thanks,
Nish
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 6 lines · Nishanth Aravamudan
Quoted 5 lines · Greg KH
Quoted 4 lines · Nishanth Aravamudan
Hi,
Please consider applying.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Description: Use
wait_event_timeout()instead of custom wait-queue code. Remove now unused variables. I changed the code to only add to the wait-queue if necessary, but I'm not sure if this is correct.Please at least compile your patches to make sure they build. This one does not :(
I'm not seeing a build error here; what errors are coming up for you?
Don't remember anymore, as I reverted the patch already...
I think it was a {} matching issue like your other patches.
thanks,
greg k-h
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors