usb/hid-core: use wait_event_timeout()
Subsystems (2)
PATCH 35/39 usb/hid-core: use wait_event_timeout()
Quoted 9 lines · Greg KH
Quoted 6 lines · Nishanth Aravamudan
Hi,
Please consider applying.
Description: Use
wait_event_timeout()instead of custom wait-queue code. Remove now unused variables.This code does not even compile :(
Sorry about that, Greg. Fixed with patch below:
Description: Use wait_event_timeout() instead of custom wait-queue code. Remove now unused variables.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/usb/input/hid-core.c +4 -16
@@ -24,6 +24,7 @@#include <asm/unaligned.h> #include <asm/byteorder.h> #include <linux/input.h> +#include <linux/wait.h> #undef DEBUG#undef DEBUG_DATA
@@ -1255,22 +1256,9 @@ void hid_submit_report(struct hid_deviceint hid_wait_io (struct hid_device *hid) { -DECLARE_WAITQUEUE (wait, current); -int timeout =10 *HZ ; - -set_current_state (TASK_UNINTERRUPTIBLE ); -add_wait_queue (&hid->wait, &wait); - -while (timeout && (test_bit (HID_CTRL_RUNNING , &hid->iofl) || -test_bit (HID_OUT_RUNNING , &hid->iofl))) { -set_current_state (TASK_UNINTERRUPTIBLE ); - timeout =schedule_timeout (timeout); - } - -set_current_state (TASK_RUNNING ); -remove_wait_queue (&hid->wait, &wait); - -if (!timeout) { +if (!wait_event_timeout (hid->wait, (!test_bit (HID_CTRL_RUNNING , &hid->iofl) && + !test_bit (HID_OUT_RUNNING , &hid->iofl)), +10 *HZ )) {dbg ("timeout waiting for ctrl or out queue to clear" );return -1 ; }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors