:Resubmitting malta support added for U-boot
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 3 lines · In message <[email protected]> you wrote:
Here is a cleaner patch incorporating your
suggestions.
Ummm... I'm afraid it is not cleaner in any way.
Sorry, but there are so many issues with your patch that I have to reject it. You really have to *check* your patch and inspect what it's doing to the source code.
Here are a few examples:
Quoted 4 lines
diff -p -u -r1.165
MakefileMakefile +0
-0@@ -42,10 +42,16 @@ VENDOR=
...
Makefile
Quoted 5 lines
ifeq (include/config.mk,$(wildcard
include/config.mk))# load ARCH, BOARD, and CPU configuration include include/config.mkMakefile +1
-1-export ARCH CPU BOARD VENDOR SOC +export ARCH CPU BOARD VENDOR
Here you kill SOC support.
Quoted 9 lines
Makefile +1
-0@@ -64,6 +70,7 @@ ifeq ($(HOSTARCH),i386) CROSS_COMPILE = else CROSS_COMPILE = i386-linux- + endif endif ifeq ($(ARCH),mips)
Makefile endif · line 88
Quoted 6 lines
Makefile +1
-1@@ -84,12 +91,14 @@ endif endif endif +CROSS_COMPILE = sde- export CROSS_COMPILE -
Arbitrary white space changes.
Makefile endif · line 101
Quoted 6 lines
Makefile +2
-0######################################################################### # U-Boot objects....order is important (i.e. start must be first) OBJS = cpu/$(CPU)/start.o + +OBJS = cpu/$(CPU)/start.o
Duplicate entry of "cpu/$(CPU)/start.o"
Makefile endif · line 103
Quoted 3 lines
Makefile +1
-1LIBS += fs/cramfs/libcramfs.a fs/fat/libfat.a fs/fdos/libfdos.a fs/jffs2/libjffs2.a \ - fs/reiserfs/libreiserfs.a fs/ext2/libext2fs.a + fs/reiserfs/libreiserfs.a
Here you kiss ext2 file system support.
Makefile endif
Quoted 5 lines
Makefile +0
-3all: $(ALL) -u-boot.hex: u-boot - $(OBJCOPY) ${OBJCFLAGS} -O ihex $< $@ -
You remove a build target.
Makefile
Quoted 2 lines
Makefile +1
-1-u-boot: depend $(SUBDIRS) $(OBJS) $(LIBS) $(LDSCRIPT) +u-boot: $(SUBDIRS) $(OBJS) $(LIBS) $(LDSCRIPT)
You kill the build system by not building the dependencies.
Makefile
Quoted 6 lines
etags:
Makefile +0
-3etags -a `find $(SUBDIRS) include \ - lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \ - fs/cramfs fs/fat fs/fdos fs/jffs2 \ - net disk rtc dtt drivers drivers/sk98lin common \ \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)`
You killt he etags target.
Makefile
Quoted 4 lines
Makefile +0
-3-incaip_100MHz_config \ -incaip_133MHz_config \ -incaip_150MHz_config \ incaip_config: unconfig
You corrupt the INKAIP board.
Makefile
Quoted 2 lines
Makefile +1
-1- rm -f tools/mpc86x_clk tools/ncb + rm -f tools/mpc86x_clk
You leave garbage hanging around.
And so on.
Sorry, but this is simply not acceptable. Please clean up (and I really mean: clean up) and resubmit.
Best regards,
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I don't know if it's what you want, but it's what you get. :-)
- Larry Wall in <[email protected]>