usb/mdc800: replace wake_up() with
Subsystems (2)
PATCH 1/1 usb/mdc800: replace wake_up() with
Quoted 11 lines · Nishanth Aravamudan
Quoted 10 lines · Greg KH
Quoted 8 lines · Nishanth Aravamudan
Hi,
Please consider applying.
Description: Use
wait_event_timeout()instead of custom wait-queue code. Remove now unused variables.Signed-off-by Nishanth Aravamudan <[email protected]>
Quoted 8 lines
Quoted 1 line
Applied, thanks.
Greg,
This should fix the behavior of the previous patch (probably not noticed yet). The wake_up*() was not matched properly in the first patch (fixed below). Please consider reverting the previous patch and applying this one instead. I think it may actually have been somewhat broken in the original code, actually :)
Description: Modify the wake_up*() calls to match the wait_event*() ones from a previous patch.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/usb/image/mdc800.c +3 -3
@@ -331,7 +331,7 @@ static void mdc800_usb_irq (struct urb * { mdc800->camera_request_ready=0 ; mdc800->irq_woken=1 ; -wake_up_interruptible (&mdc800->irq_wait); +wake_up (&mdc800->irq_wait); } }
@@ -386,7 +386,7 @@ static void mdc800_usb_write_notify (str mdc800->state=READY ; } mdc800->written =1 ; -wake_up_interruptible (&mdc800->write_wait); +wake_up (&mdc800->write_wait); }
@@ -414,7 +414,7 @@ static void mdc800_usb_download_notify (err ("request bytes fails (status:%i)" , urb->status); } mdc800->downloaded =1 ; -wake_up_interruptible (&mdc800->download_wait); +wake_up (&mdc800->download_wait); }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors