w1/w1: remove
Quoted 16 lines · Evgeniy Polyakov
Quoted 1 line · On Wed, 2 Feb 2005 11:14:18 -0800 Nishanth Aravamudan <[email protected]> wrote:
Hello,
Hello.
Quoted 8 lines
Please consider applying.
Description: Replace deprecated
interruptible_sleep_on_timeout()with direct wait-queue usage. Ideally, I would usewait_event_interruptible_timeout(); however, there is no condition to sleep on here, unless I was to use thetry_to_freeze()call as one. That is not the case in the current code, though, and I'm not sure it can/should be. Since timeout is a jiffies-unit variable, change the type to unsigned long. Patch is compile-tested.
Quoted 6 lines
Second part of the
patch(changing w1_process() sleeping path)is not 100% right. Although all those sleeps are just waitings for given timeout to check various flags - since awakening only happens on signal, we can just replace them withmsleep_interruptible()and appropriatetry_to_freeze().I will prepare a patch tomorrow, thank you.
Ok, thanks for the prompt feedback!
-Nish
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors