Skip to contentSkip to conversation

usb/io_edgeport: remove

PATCH Greg KH 1 participant 1 message Feb 4, 2005 Kernel janitors

lore
Share & tools
lore

Greg KH

author Applied
#0 lore raw
Quoted 47 lines · Nishanth Aravamudan
Quoted 23 lines · Nishanth Aravamudan
Quoted 5 lines · Greg KH
Quoted 4 lines · Nishanth Aravamudan

Hi,

Please consider applying.

Quoted 7 lines
Quoted 5 lines

Description: Use wait_event_timeout() instead of deprecated interruptible_sleep_on_timeout(). Signals are not checked in the current code, so interruptible should not be necessary. Patch is compile-tested.

Applied, thanks.

Greg,

This should fix the behavior of the previous patch (probably not noticed yet). The wake_up*() was not matched properly in the first patch (fixed below). Please consider reverting the previous patch and applying this one instead.

Thanks,
Nish

Quoted 8 lines

interruptible_sleep_on_timeout() in one place. Directly use wait-queues in other locations to remove remaining callers of interruptible_sleep_on_timeout(). Signals are not checked in the current code, so interruptible should not be necessary. Thus, the wake_up*() calls were modified to match the wait_event*() ones. There were some naming conflicts, which I tried to resolve appropriately. The final replacement is within a #if 0 / #endif section of code, but in case that code is ever used again, I would prefer it had the correct interface :) Patch is compile-tested.

This and the mdc800 patch that I sent are incremental to fix wake_up*() callers, as Greg requested on IRC.

Thanks,
Nish

Description: Directly use wait-queues to remove remaining callers of interruptible_sleep_on_timeout(). Signals are not checked (except in one case) in the current code, so interruptible should not be necessary. Modify the wake_up*() calls to match the wait-queue usage. There were some naming conflicts, which I tried to resolve appropriately. The final replacement is within a #if 0 / #endif section of code, but in case that code is ever used again, I would prefer it had the correct interface :) Patch is compile-tested.

Quoted 1 line

Applied, thanks.

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors