Skip to contentSkip to conversation

IDE: unsexport 3 functions

RFC PATCH In review Adrian Bunk 2 participants 3 messages Feb 5, 2005 – Feb 6, 2005 libata

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 IDE: unsexport 3 functions

The patch removes three unneeded EXPORT_SYMBOL's.

---

 drivers/ide/ide-iops.c     |    4 ----
 drivers/ide/ide-taskfile.c |    2 --
 2 files changed, 6 deletions(-)
drivers/ide/ide-iops.c renamed from drivers/ide/ide-iops.c.old +0 -4
@@ -104,8 +104,6 @@
 	hwif->INSL	= ide_insl;
 }
 
-EXPORT_SYMBOL(default_hwif_iops);
-
 /*
  *	MMIO operations, typically used for SATA controllers
  */
@@ -329,8 +327,6 @@
 	hwif->atapi_output_bytes	= atapi_output_bytes;
 }
 
-EXPORT_SYMBOL(default_hwif_transport);
-
 /*
  * Beginning of Taskfile OPCODE Library and feature sets.
  */
drivers/ide/ide-taskfile.c renamed from drivers/ide/ide-taskfile.c.old +0 -2
@@ -161,8 +161,6 @@
 	return ide_stopped;
 }
 
-EXPORT_SYMBOL(do_rw_taskfile);
-
 /*
  * set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
  */
#1 lore raw

drivers/ide/ide-taskfile.c line 165

Quoted 6 lines
drivers/ide/ide-taskfile.c renamed from drivers/ide/ide-taskfile.c.old +0 -2
@@ -161,8 +161,6 @@
        return ide_stopped;
 }
 
-EXPORT_SYMBOL(do_rw_taskfile);
-

Is this patch against -mm or ide-dev-2.6?

do_rw_taskfile() is still needed for ide-disk.c in linus' tree, the other two exports can be removed

#2 lore raw
Quoted 8 lines · Bartlomiej Zolnierkiewicz

drivers/ide/ide-taskfile.c line 165

Quoted 6 lines
drivers/ide/ide-taskfile.c renamed from drivers/ide/ide-taskfile.c.old +0 -2
@@ -161,8 +161,6 @@
        return ide_stopped;
 }
 
-EXPORT_SYMBOL(do_rw_taskfile);
-

Is this patch against -mm or ide-dev-2.6?

This is against -mm.
But the only changes regarding do_rw_taskfile in -mm come from bk-ide-dev.

Quoted 2 lines

do_rw_taskfile() is still needed for ide-disk.c in linus' tree, the other two exports can be removed

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed