Skip to contentSkip to conversation

PCI access mode on x86_64

DISCUSSION Applied Piotr Kaczuba 3 participants 7 messages Feb 13, 2005 – Feb 17, 2005 PCI

lore
Share & tools
lore
#0 lore raw

Hi!

Is there a reason why "PCI access mode" config option isn't available for x86_64? Due to this, PCIE config options aren't available either.

Piotr Kaczuba

#1 lore raw
Quoted 4 lines · Piotr Kaczuba

Hi!

Is there a reason why "PCI access mode" config option isn't available for x86_64? Due to this, PCIE config options aren't available either.

There is no 64bit PCI BIOS, so access is always direct.

I assume you mean mmconfig access with "PCIE config options", that is a separate config option and available.

-Andi

#2 lore raw
Quoted 8 lines · Andi Kleen
Quoted 2 lines · Piotr Kaczuba

Is there a reason why "PCI access mode" config option isn't available for x86_64? Due to this, PCIE config options aren't available either.

There is no 64bit PCI BIOS, so access is always direct.

I assume you mean mmconfig access with "PCIE config options", that is a separate config option and available.

I mean the PCIEPORTBUS option which depends on PCI_GOMMCONFIG or PCI_GOANY. I assume that due to PCI_MMCONFIG / PCI_GOMMCONFIG mismatch it's not available on x86_64.

Piotr Kaczuba

#3 lore raw
Quoted 5 lines · Piotr Kaczuba
Quoted 4 lines · Andi Kleen
Quoted 2 lines · Piotr Kaczuba

Is there a reason why "PCI access mode" config option isn't available for x86_64? Due to this, PCIE config options aren't available either.

Quoted 8 lines
Quoted 4 lines

There is no 64bit PCI BIOS, so access is always direct.

I assume you mean mmconfig access with "PCIE config options", that is a separate config option and available.

I mean the PCIEPORTBUS option which depends on PCI_GOMMCONFIG or PCI_GOANY. I assume that due to PCI_MMCONFIG / PCI_GOMMCONFIG mismatch it's not available on x86_64.

Ok, that's a bug in PCIEPORTBUS. Best is probably to completely remove the dependency, it doesn't make much sense (the code has to handle the case of mmconfig not being available at runtime anyways)

-Andi

Remove bogus dependency in PCI Express root driver.

drivers/pci/pcie/Kconfig renamed from drivers/pci/pcie/Kconfig-o +0 -1
diff -u linux-2.6.11rc3/drivers/pci/pcie/Kconfig-o linux-2.6.11rc3/drivers/pci/pcie/Kconfig
@@ -3,7 +3,6 @@
 #
 config PCIEPORTBUS
 	bool "PCI Express support"
-	depends on PCI_GOMMCONFIG || PCI_GOANY
 	default n
 
 	---help---
#4 lore raw
Quoted 31 lines · Andi Kleen
Quoted 5 lines · Piotr Kaczuba
Quoted 4 lines · Andi Kleen
Quoted 2 lines · Piotr Kaczuba

Is there a reason why "PCI access mode" config option isn't available for x86_64? Due to this, PCIE config options aren't available either.

Quoted 8 lines
Quoted 4 lines

There is no 64bit PCI BIOS, so access is always direct.

I assume you mean mmconfig access with "PCIE config options", that is a separate config option and available.

I mean the PCIEPORTBUS option which depends on PCI_GOMMCONFIG or PCI_GOANY. I assume that due to PCI_MMCONFIG / PCI_GOMMCONFIG mismatch it's not available on x86_64.

Ok, that's a bug in PCIEPORTBUS. Best is probably to completely remove the dependency, it doesn't make much sense (the code has to handle the case of mmconfig not being available at runtime anyways)

-Andi

Remove bogus dependency in PCI Express root driver.

diff -u linux-2.6.11rc3/drivers/pci/pcie/Kconfig-o linux-2.6.11rc3/drivers/pci/pcie/Kconfig

drivers/pci/pcie/Kconfig line 8

Quoted 7 lines
drivers/pci/pcie/Kconfig renamed from drivers/pci/pcie/Kconfig-o +0 -1
@@ -3,7 +3,6 @@
 #
 config PCIEPORTBUS
 	bool "PCI Express support"
-	depends on PCI_GOMMCONFIG || PCI_GOANY
 	default n
 
 	---help---

This one is needed, too.

Piotr Kaczuba

arch/x86_64/Kconfig 2005-02-14 16:37:18.000000000 +0100 renamed from arch/x86_64/Kconfig 2005-02-14 16:37:33.000000000 +0100 +2 -0
@@ -399,6 +399,8 @@
         from i386. Requires that the driver writer used memory barriers
         properly.
 
+source "drivers/pci/pcie/Kconfig"
+
 source "drivers/pci/Kconfig"
 
 source "drivers/pcmcia/Kconfig"
#5 lore raw
Quoted 1 line

This one is needed, too.

Thanks. Whoever wrote this this didn't care very much about x86-64.

-Andi

Applied
#6 lore raw
In reply to Andi Kleen
Quoted 15 lines · Andi Kleen
Quoted 5 lines · Piotr Kaczuba
Quoted 4 lines · Andi Kleen
Quoted 2 lines · Piotr Kaczuba

Is there a reason why "PCI access mode" config option isn't available for x86_64? Due to this, PCIE config options aren't available either.

Quoted 8 lines
Quoted 4 lines

There is no 64bit PCI BIOS, so access is always direct.

I assume you mean mmconfig access with "PCIE config options", that is a separate config option and available.

I mean the PCIEPORTBUS option which depends on PCI_GOMMCONFIG or PCI_GOANY. I assume that due to PCI_MMCONFIG / PCI_GOMMCONFIG mismatch it's not available on x86_64.

Quoted 8 lines

Ok, that's a bug in PCIEPORTBUS. Best is probably to completely remove the dependency, it doesn't make much sense (the code has to handle the case of mmconfig not being available at runtime anyways)

-Andi

Remove bogus dependency in PCI Express root driver.

Applied, thanks.

greg k-h