Skip to contentSkip to conversation

drivers/atm/ remove pci_find_{device, subsys}

PATCH In review Amit Gud 3 participants 3 messages Feb 14, 2005 – Feb 15, 2005

Subsystems (2)
Kernel janitors ATM
lore
Share & tools
lore

Amit Gud

author
#0 lore raw

PATCH 2/18 drivers/atm/ remove pci_find_{device, subsys}

Remove deprecated pci_find_device and pci_find_subsys

AG
--
May the source be with you

Signed-off-by Amit Gud <[email protected]>
drivers/atm/fore200e.c +1 -1
diff -uprN orig/drivers/atm/fore200e.c linux-2.6.11-rc3/drivers/atm/fore200e.c
@@ -645,7 +645,7 @@ fore200e_pca_detect(const struct fore200
     int              count = index;
     
     do {
-	pci_dev = pci_find_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
+	pci_dev = pci_get_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
 	if (pci_dev == NULL)
 	    return NULL;
     } while (count--);

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 15 lines · Amit Gud

Remove deprecated pci_find_device and pci_find_subsys

AG
--
May the source be with you

Signed-off-by Amit Gud <[email protected]>

diff -uprN orig/drivers/atm/fore200e.c linux-2.6.11-rc3/drivers/atm/fore200e.c

drivers/atm/fore200e.c fore200e_pca_detect(const struct fore200 · line 651

Quoted 8 lines
drivers/atm/fore200e.c +1 -1
@@ -645,7 +645,7 @@ fore200e_pca_detect(const struct fore200
     int              count = index;
 
     do {
-	pci_dev = pci_find_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
+	pci_dev = pci_get_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E, pci_dev);
 	if (pci_dev == NULL)
 	    return NULL;
     } while (count--);

No, this is incorrect, please do not apply.

greg k-h

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Amit Gud
Quoted 5 lines · In message <[email protected]>,Greg KH writes:

Review

Quoted 1 line
(quoted diff) +0 -1
-	pci_dev = pci_find_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200

E, pci_dev);

Review

Quoted 1 line
(quoted diff) +1 -0
+	pci_dev = pci_get_device(PCI_VENDOR_ID_FORE, PCI_DEVICE_ID_FORE_PCA200E

No, this is incorrect, please do not apply.

i have a patch that fixes this the right way. i will submit it later this week.

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors