Skip to contentSkip to conversation

drivers/net/via-rhine.c: make a variable static

PATCH In review Adrian Bunk 2 participants 3 messages Feb 19, 2005 – Feb 21, 2005 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/net/via-rhine.c: make a variable static

This patch makes a needlessly global variable static.

drivers/net/via-rhine.c renamed from drivers/net/via-rhine.c.old +1 -1
@@ -390,7 +390,7 @@
 
 #ifdef USE_MMIO
 /* Registers we check that mmio and reg are the same. */
-int mmio_verify_registers[] = {
+static int mmio_verify_registers[] = {
 	RxConfig, TxConfig, IntrEnable, ConfigA, ConfigB, ConfigC, ConfigD,
 	0
 };
#1 lore raw
Quoted 7 lines · Adrian Bunk

This patch makes a needlessly global variable static.

drivers/net/via-rhine.c line 395

Quoted 7 lines
drivers/net/via-rhine.c renamed from drivers/net/via-rhine.c.old +1 -1
@@ -390,7 +390,7 @@
 
 #ifdef USE_MMIO
 /* Registers we check that mmio and reg are the same. */
-int mmio_verify_registers[] = {
+static int mmio_verify_registers[] = {
 	RxConfig, TxConfig, IntrEnable, ConfigA, ConfigB, ConfigC, ConfigD,
 	0

static const

Jeff

#2 lore raw

PATCH 1/1 drivers/net/via-rhine.c: make a variable static const

Quoted 8 lines · Jeff Garzik

Adrian Bunk wrote:
...

Quoted 4 lines
(quoted diff) +1 -1
-int mmio_verify_registers[] = {
+static int mmio_verify_registers[] = {
	RxConfig, TxConfig, IntrEnable, ConfigA, ConfigB, ConfigC, ConfigD,
	0

static const

Updated patch below.

<-- snip -->

This patch makes a needlessly global variable static const.

drivers/net/via-rhine.c renamed from drivers/net/via-rhine.c.old +1 -1
@@ -390,7 +390,7 @@
 
 #ifdef USE_MMIO
 /* Registers we check that mmio and reg are the same. */
-int mmio_verify_registers[] = {
+static const int mmio_verify_registers[] = {
 	RxConfig, TxConfig, IntrEnable, ConfigA, ConfigB, ConfigC, ConfigD,
 	0
 };